New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661672 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit 20 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ARC intents: collect metrics on intent destination

Project Member Reported by elijahtaylor@chromium.org, Nov 2 2016

Issue description

Currently we collect user actions from the intent dialog (always, once, dismiss, not shown), but it doesn't tell us where the user ends up.  We should collect information on whether the user stayed in Chrome or ended up in an Android app for intent disambiguation.

If this change is simple, I'd like to try to merge to M-55 and start collecting information in beta.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0465d157795b6f988a795763ad4ef4faa6d994a

commit a0465d157795b6f988a795763ad4ef4faa6d994a
Author: djacobo <djacobo@google.com>
Date: Sun Nov 06 03:46:13 2016

Adding a destination platform histogram for UMA.

This enum helps to keep track of whether a navigation observed by
ArcNavigationThrottle is continued in Chrome or redirected to a ARC.
Likewise it helps determinating if a navigation is continued in Chrome
or redirected to ARC via the external protocol dialog.

BUG= 661672 
TEST=try

Review-Url: https://codereview.chromium.org/2476783002
Cr-Commit-Position: refs/heads/master@{#430176}

[modify] https://crrev.com/a0465d157795b6f988a795763ad4ef4faa6d994a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
[modify] https://crrev.com/a0465d157795b6f988a795763ad4ef4faa6d994a/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc
[modify] https://crrev.com/a0465d157795b6f988a795763ad4ef4faa6d994a/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
[modify] https://crrev.com/a0465d157795b6f988a795763ad4ef4faa6d994a/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc
[modify] https://crrev.com/a0465d157795b6f988a795763ad4ef4faa6d994a/tools/metrics/histograms/histograms.xml

Comment 2 by djacobo@google.com, Nov 10 2016

I just had the chance to try a Chrome OS version that includes this change, do we still need it for M55? If so let's start the merge-request
Labels: -M-55 M-56
Status: Fixed (was: Assigned)
thinking about it more, I think M-56 is fine actually.  Let's just mark Fixed
Status: Verified (was: Fixed)

Sign in to add a comment