New issue
Advanced search Search tips

Issue 661664 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Convert all callers of [Tab goBack] and [Tab goForward]

Project Member Reported by stkhapugin@chromium.org, Nov 2 2016

Issue description

See todo in tab.h
 
Labels: -Type-Bug Type-Feature
Status: Available (was: Unconfirmed)
Components: UI>Browser>Navigation
Labels: -Type-Feature Type-Task
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: eugene...@chromium.org
The TODO's still valid and there are still a few calls to [Tab go{Back|Forward}] as of today.
Status: Available (was: Untriaged)
Owner: mrefaat@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Yesterday (35 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cd609afcf8825991fadd04feeae2baaaa1fc9fb

commit 4cd609afcf8825991fadd04feeae2baaaa1fc9fb
Author: mrefaat <mrefaat@chromium.org>
Date: Tue Jan 22 18:34:47 2019

Remove Tab's navigation methods

Removes: goBack, canGoBack, goForward and canGoForward

Bug: 661664,  899598 ,  899423 
Change-Id: Ia1b781d6827ffc50ca2fe18c513e67d7f4ac2b15
Reviewed-on: https://chromium-review.googlesource.com/c/1372174
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624844}
[modify] https://crrev.com/4cd609afcf8825991fadd04feeae2baaaa1fc9fb/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/4cd609afcf8825991fadd04feeae2baaaa1fc9fb/ios/chrome/browser/tabs/tab.mm

Sign in to add a comment