Switch to TestBrowserState once SessionWindowIOSTest is moved to ios_web_unittests. |
|||||
Issue descriptionAddress TODO in SessionWindowIOSTest: Switch to TestBrowserState once this test is moved to be in the ios_web_unittests target.
,
Nov 7 2016
Kurt, do we even plan moving SessionWindowIOS to ios/web? I remember you had a plan to refactor session serialization some time ago.
,
Nov 10 2016
The plan is that we're going to replace WebStateImpl::CopyForSessionWindow() and NavigationManagerImpl::CopyState() into two functions called CopyForSerialization(), which will return an NSObject<NSCoding> that can be used from SessionWindowIOS. This decoupling would make us more in line with what happens in the sessions component for content//. That being said, I definitely wouldn't be opposed to moving that functionality into web// and leaving only the SessionServiceIOS code in the chrome/ layer.
,
Nov 10 2016
,
Mar 15 2017
,
Apr 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 11 2018
TODO 661639 does not exist. Also SessionWindowIOSTest will not be moved to ios/web. I think this bug is obsolete now. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pkl@chromium.org
, Nov 7 2016Owner: eugene...@chromium.org
Status: Assigned (was: Unconfirmed)