New issue
Advanced search Search tips

Issue 661637 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Expose BaseAudioContext

Project Member Reported by hongchan@chromium.org, Nov 2 2016

Issue description

Currently BaseAudioContext IDL contains '[NoInterfaceObject]' property. Remove this per spec and expose the class in the global scope.
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ec22676c144539f37f15740f4d712bb298ea02a

commit 5ec22676c144539f37f15740f4d712bb298ea02a
Author: hongchan <hongchan@chromium.org>
Date: Thu Nov 10 00:40:04 2016

Expose BaseAudioContext prototype

Refactoring of BaseAudioContext (https://codereview.chromium.org/1865583002)
changed the prototype structure of AudioContext/OfflineAudioContext and
developers could not call hasOwnProperty() on BaseAudioContext because
it was not exposed to the JS domain.

This CL exposes BaseAudioContext's prototype. Also it adds 3 new layout
tests for each audio context and removes the old context property test.

BUG= 555608 ,  661637 
TEST=
LayoutTests/webaudio/baseaudiocontext-properties.html
LayoutTests/webaudio/audiocontext-properties.html
LayoutTests/webaudio/offlineaudiocontext-properties.html

Review-Url: https://codereview.chromium.org/2386303002
Cr-Commit-Position: refs/heads/master@{#431105}

[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt
[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/webaudio/audiocontext-properties.html
[add] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/webaudio/baseaudiocontext-properties.html
[delete] https://crrev.com/47a013537bc0f554137b3ac2db6ce7762ff624f6/third_party/WebKit/LayoutTests/webaudio/context-properties-expected.txt
[delete] https://crrev.com/47a013537bc0f554137b3ac2db6ce7762ff624f6/third_party/WebKit/LayoutTests/webaudio/context-properties.html
[add] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-properties.html
[add] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/webaudio/resources/context-properties.js
[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/Source/modules/webaudio/AudioContext.idl
[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl
[modify] https://crrev.com/5ec22676c144539f37f15740f4d712bb298ea02a/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.idl

Status: Verified (was: Started)

Sign in to add a comment