New issue
Advanced search Search tips

Issue 661630 link

Starred by 2 users

Issue metadata

Status: ExternalDependency
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove clear cookies workaround when WKWebView is fixed

Project Member Reported by stkhapugin@chromium.org, Nov 2 2016

Issue description

Address todo in browsing_data_removal_controller.mm removeWKWebViewCreatedBrowsingDataFromBrowserState:mask:deleteBegin:completionHandler:
 
Labels: -Type-Bug Type-Feature
Status: ExternalDependency (was: Unconfirmed)
Remove workaround for https://bugs.webkit.org/show_bug.cgi?id=149078 which is not fixed.
 Issue 661631  has been merged into this issue.
Components: Internals>Network>Cookies
Components: -Internals>Network>Cookies Privacy
Labels: -Type-Feature Type-Task
Workaround is still needed for iOS 11.
Owner: mrefaat@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df1faf58269795271644b585d24597e47a6b00c

commit 0df1faf58269795271644b585d24597e47a6b00c
Author: Mohammad Refaat <mrefaat@chromium.org>
Date: Mon Apr 16 21:34:03 2018

Fix Clear cookies with WKHTTPCookieStore

Accessing cookies from WKHTTPCookieStore doesn't work correctly when
there is not a  WKWebView object alive. previously a work around was
created, but it seems to not solve the problem.
The problem always existed but to be able to WKHTTPCookieStore as the
main cookieStore, it had to be addressed.

Bug: 661630, 746947
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie5f67102a7cfb804a47b8aa5c1316c25be5d9609
Reviewed-on: https://chromium-review.googlesource.com/1011584
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551127}
[modify] https://crrev.com/0df1faf58269795271644b585d24597e47a6b00c/ios/chrome/browser/browsing_data/browsing_data_remover_impl.h
[modify] https://crrev.com/0df1faf58269795271644b585d24597e47a6b00c/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df1faf58269795271644b585d24597e47a6b00c

commit 0df1faf58269795271644b585d24597e47a6b00c
Author: Mohammad Refaat <mrefaat@chromium.org>
Date: Mon Apr 16 21:34:03 2018

Fix Clear cookies with WKHTTPCookieStore

Accessing cookies from WKHTTPCookieStore doesn't work correctly when
there is not a  WKWebView object alive. previously a work around was
created, but it seems to not solve the problem.
The problem always existed but to be able to WKHTTPCookieStore as the
main cookieStore, it had to be addressed.

Bug: 661630, 746947
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie5f67102a7cfb804a47b8aa5c1316c25be5d9609
Reviewed-on: https://chromium-review.googlesource.com/1011584
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551127}
[modify] https://crrev.com/0df1faf58269795271644b585d24597e47a6b00c/ios/chrome/browser/browsing_data/browsing_data_remover_impl.h
[modify] https://crrev.com/0df1faf58269795271644b585d24597e47a6b00c/ios/chrome/browser/browsing_data/browsing_data_remover_impl.mm

Sign in to add a comment