Address the TODO in FormSuggestionControllerTest in SetUpController()
Bulk transfer of autofill bugs from jdonnelly@ to mahmadi@.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96 commit c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Fri Aug 10 04:32:28 2018 [iOS][AF] Create FormInputAccessoryMediator This CL moves all the logic from the FormInputAccessoryViewController that is not directly related to managing its view to a new mediator. Creates a consumer for the communication the the view controller. Updates tests to use this mediator instead. Removes the dependency on the CRWWebViewProxy. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1b0f6c595f069ea45e04c9dacdc4437dbfe9041a Bug: 661622, 727716, 845472 , 847408 Reviewed-on: https://chromium-review.googlesource.com/1130522 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#582056} [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/BUILD.gn [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/autofill_controller_unittest.mm [add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_consumer.h [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_controller.h [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm [add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_handler.h [add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_handler.mm [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_provider.h [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_egtest.mm [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_suggestion_controller.mm [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/passwords/BUILD.gn [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/passwords/password_controller_unittest.mm [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/BUILD.gn [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm [add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.h [add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/web/public/web_state/ui/crw_web_view_proxy.h [modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/web/web_state/ui/crw_web_view_proxy_impl.mm
Comment 1 by jyqu...@chromium.org
, Nov 2 2016Status: Assigned (was: Untriaged)