New issue
Advanced search Search tips

Issue 661609 link

Starred by 3 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Support native pages in VR

Project Member Reported by mthiesse@chromium.org, Nov 2 2016 
Either re-implement, or support existing native pages in VR.

Native pages with URLs:
NTP,
BOOKMARKS,
DOWNLOADS,
RECENT_TABS,
PHYSICAL_WEB

Native pages without URLs(?):
Aw Snap!
others?


We should be able to run through all of the URLs at chrome://chrome-urls/, and behave sanely.

Comment 2 by ddorwin@chromium.org, Dec 5 2016

Labels: -VR-Fishfood VR-DF
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f989aaee547259373cf231cfcf32c23729c154d

commit 7f989aaee547259373cf231cfcf32c23729c154d
Author: mthiesse <mthiesse@chromium.org>
Date: Mon Feb 13 21:45:43 2017

Support rendering Android Native Pages in VR Shell.

Input to these native pages is not yet implemented.

BUG= 661609 

Review-Url: https://codereview.chromium.org/2683953007
Cr-Commit-Position: refs/heads/master@{#450102}

[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/DEPS
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/vr_compositor.cc
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/7f989aaee547259373cf231cfcf32c23729c154d/chrome/browser/android/vr_shell/vr_shell_gl.h

Comment 5 by mthiesse@chromium.org, Feb 15 2017

Owner: mthiesse@chromium.org
Status: Started (was: Available)

Comment 6 by mthiesse@chromium.org, Feb 16 2017 

Things that still don't work after https://codereview.chromium.org/2694103006/ lands:
chrome-native://recent-tabs/ doesn't scroll.
chrome://history doesn't fling(?!).
chrome-native://bookmarks/ and chrome-native://downloads/ can't enter VR (they're in their own activities).

(Will file separate bugs)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ba7911391a74da0f186b82801d3d6279a197589

commit 8ba7911391a74da0f186b82801d3d6279a197589
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Feb 24 23:58:33 2017

Inject vr controller events into Android Native UI.

Generalizes the MotionEventSynthesizer to support input into arbitrary Java views, and connects VR controller/gesture output to the MotionEventSynthesizer.

This also fixes some rendering bugs where onDraw was not being called after scrolling preventing the texture from updating correctly.

BUG= 661609 

Review-Url: https://codereview.chromium.org/2694103006
Cr-Commit-Position: refs/heads/master@{#453004}

[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/PRESUBMIT.py
[add] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/android_ui_gesture_target.cc
[add] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/android_ui_gesture_target.h
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/vr_controller.h
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/8ba7911391a74da0f186b82801d3d6279a197589/content/public/android/java/src/org/chromium/content/browser/MotionEventSynthesizer.java

Comment 8 by mthiesse@chromium.org, May 4 2017

Status: Fixed (was: Started)

Comment 9 by ddorwin@chromium.org, May 4 2017

Labels: -Proj-VR Proj-VR-Shell
►

Sign in to add a comment