New issue
Advanced search Search tips

Issue 661592 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

safeIndex >= 0

Project Member Reported by ClusterFuzz, Nov 2 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4640291090071552

Fuzzer: libfuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  safeIndex >= 0
  TParseContext::addIndexExpression
  yyparse
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=420312:420423

Minimized Testcase (0.51 Kb): https://cluster-fuzz.appspot.com/download/AMIfv949Un6YMtamsYwIeX5B12TKz9IzzDqQrYGoixXskJWpWMUDtTwmTkxhrxhRkP-fBydY0vnQU3OhkgCn-cCd2xA8ZbXWD1onYrC13h30yoEQKO3JW1RCSfgBGY42G9HZgHVhbNL2EJ6LHCr_U_UVjzHpd7kucQ?testcase_id=4640291090071552

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Owner: jmad...@chromium.org
Status: Assigned (was: Untriaged)
jmadill@ could you please look into this.please feel free to re-assigned back if needed. thanks in advance !
Cc: jmad...@chromium.org
Components: Internals>GPU>ANGLE
Owner: cwallez@chromium.org
Passing to cwallez, care to take a look?
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/02bd82cd1d4e9d30e2f53917d97f1980a4e2dbd4

commit 02bd82cd1d4e9d30e2f53917d97f1980a4e2dbd4
Author: Olli Etuaho <oetuaho@nvidia.com>
Date: Thu Nov 03 10:29:43 2016

Fix handling unsized arrays with incorrect initializer

In case the initializer of an unsized array is not an array, the array
size still needs to be set to some value > 0 in order to not hit
asserts in the code that parses accessing the array. An error was
already being generated in the case an unsized array has a non-array
initializer, but the variable will still have an array type in the
symbol table.

BUG= chromium:661592 
TEST=angle_unittests

Change-Id: I4a11527eab0404ba9e59ebb7227faef13dbea62c
Reviewed-on: https://chromium-review.googlesource.com/407256
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

[modify] https://crrev.com/02bd82cd1d4e9d30e2f53917d97f1980a4e2dbd4/src/compiler/translator/ParseContext.cpp
[modify] https://crrev.com/02bd82cd1d4e9d30e2f53917d97f1980a4e2dbd4/src/tests/compiler_tests/MalformedShader_test.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b42220eced72b0a5333ba28c6dd7ccf3a5178d40

commit b42220eced72b0a5333ba28c6dd7ccf3a5178d40
Author: ynovikov <ynovikov@chromium.org>
Date: Fri Nov 04 19:27:25 2016

Roll ANGLE eb66a6e..bbe9fb5

https://chromium.googlesource.com/angle/angle.git/+log/eb66a6e..bbe9fb5

BUG=None,chromium:568170,chromium:660854,chromium:661592

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2479673003
Cr-Commit-Position: refs/heads/master@{#429975}

[modify] https://crrev.com/b42220eced72b0a5333ba28c6dd7ccf3a5178d40/DEPS

Project Member

Comment 5 by ClusterFuzz, Nov 5 2016

ClusterFuzz has detected this issue as fixed in range 429934:429988.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4640291090071552

Fuzzer: libfuzzer_angle_translator_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  safeIndex >= 0
  TParseContext::addIndexExpression
  yyparse
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=420312:420423
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan_debug&range=429934:429988

Minimized Testcase (0.51 Kb): https://cluster-fuzz.appspot.com/download/AMIfv949Un6YMtamsYwIeX5B12TKz9IzzDqQrYGoixXskJWpWMUDtTwmTkxhrxhRkP-fBydY0vnQU3OhkgCn-cCd2xA8ZbXWD1onYrC13h30yoEQKO3JW1RCSfgBGY42G9HZgHVhbNL2EJ6LHCr_U_UVjzHpd7kucQ?testcase_id=4640291090071552

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Nov 5 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment