New issue
Advanced search Search tips

Issue 661530 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 660558
Owner: ----
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.4% regression in memory.top_10_mobile_stress at 427977:428001

Project Member Reported by primiano@chromium.org, Nov 2 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=661530

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgg_6EsAkM


Bot(s) for this bug's original alert(s):

android-nexus5
Mergedinto: 660558
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [Turbofan] Add concept of FP register aliasing on ARM 32.
Author  : bbudge
Commit description:
  
- Modifies RegisterConfiguration to specify complex aliasing on ARM 32.
- Modifies RegisterAllocator to consider aliasing.
- Modifies ParallelMove::PrepareInsertAfter to handle aliasing.
- Modifies GapResolver to split wider register moves when interference
with smaller moves is detected.
- Modifies MoveOptimizer to handle aliasing.
- Adds ARM 32 macro-assembler pseudo move instructions to handle cases where
  split moves don't correspond to actual s-registers.
- Modifies CodeGenerator::AssembleMove and AssembleSwap to handle moves of
  different widths, and moves involving pseudo-s-registers.
- Adds unit tests for FP operand interference checking and PrepareInsertAfter.
- Adds more tests of FP for the move optimizer and register allocator.

LOG=N
BUG= v8:4124 

Review-Url: https://codereview.chromium.org/2410673002
Cr-Commit-Position: refs/heads/master@{#40597}
Commit  : 09ab8e6ad9440d15f3083a44ca0c1ab3ae84a036
Date    : Wed Oct 26 16:04:33 2016


===== TESTED REVISIONS =====
Revision                       Mean     Std Dev  N  Good?
chromium@427976                7789110  100993   5  good
chromium@427989                7886729  162405   5  good
chromium@427995                7805419  69715.9  8  good
chromium@427998                7881326  233948   8  good
chromium@427998,v8@f6c3fd0a74  7799826  121722   5  good
chromium@427998,v8@09ab8e6ad9  8112094  101680   5  bad    <--
chromium@427998,v8@46a1b34e86  8172093  129896   5  bad
chromium@427998,v8@ff5194e3ce  8172239  166709   5  bad
chromium@427998,v8@24d38be132  8129833  93174.8  8  bad
chromium@427999                8114901  78790.9  8  bad
chromium@428000                8090858  47629.5  8  bad
chromium@428001                8184644  110269   8  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 661530

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress
Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/foreground/http_www_amazon_com_gp_aw_s_k_nexus
Relative Change: 5.64%
Score: 99.5

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4316
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997108277310417152


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5875677201432576

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment