New issue
Advanced search Search tips

Issue 661515 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 661500
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.5% regression in memory.top_10_mobile at 428127:428238

Project Member Reported by primiano@chromium.org, Nov 2 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=661515

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgg56G_goM


Bot(s) for this bug's original alert(s):

android-nexus7v2
Cc: dcheng@chromium.org
Owner: dcheng@chromium.org

=== Auto-CCing suspected CL author dcheng@chromium.org ===

Hi dcheng@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Remove AppBannerManager code to skip secure context checks for tests.
Author  : dcheng
Commit description:
  
localhost is always considered secure.

BUG=none

Review-Url: https://codereview.chromium.org/2434623002
Cr-Commit-Position: refs/heads/master@{#428235}
Commit  : 3ab83d44b0f52114c2e6344ba7ab516f967ed8a8
Date    : Fri Oct 28 01:43:12 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@428126  1139371  6164.05  18  good
chromium@428182  1138688  6050.19  12  good
chromium@428210  1138688  5960.56  18  good
chromium@428224  1139371  6164.05  18  good
chromium@428231  1136128  4344.46  8   good
chromium@428233  1138233  5717.87  27  good
chromium@428234  1137323  5205.93  27  good
chromium@428235  1142101  6164.05  18  bad    <--
chromium@428238  1149156  8218.73  18  bad

Bisect job ran on: android_nexus7_perf_bisect
Bug ID: 661515

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/background/after_http_m_intl_taobao_com_group_purchase_html
Relative Change: 1.15%
Score: 95.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3443
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997110337663438992


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5810701325565952

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
My CL is -25 lines and 1 changed line (which is merging the brace from the line that's deleted) and removed a test-only bool that's only set to true in tests.

Any possibility the bisect is wrong?
Owner: primiano@chromium.org
Status: WontFix (was: Untriaged)
This entire bug is about 4k of discardable memory. The day that the memory problems of Chrome will be of the order of 4k I will be sipping Mojito on a beach.
Sorry but didn't realize about the cardinality of this regression when triaging (112 alerts yesterday :/). We have a bug open about the fact that % is highly misleading.

This is not worth anybody's time.
Mergedinto: 661500
Status: Duplicate (was: WontFix)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Convert app banners to use Mojo.
Author  : dominickn
Commit description:
  
This CL converts the app banner system from Chrome IPC to Mojo and moves
all banner code from chrome/renderer to Blink. It also substantially
improves the layout test coverage for the BeforeInstallPromptEvent,
fixing various renderer crash bugs that are covered by the tests.

The key change is that the browser-side AppBannerManager makes a Mojo
request to Blink, which is intercepted by the WebLocalFrame and rerouted
to the AppBannerController. The AppBannerManager passes a bound
InterfaceRequest/Ptr in the Mojo request, which are used to create a
bound BeforeInstallPromptEvent. This ensures that when a
BeforeInstallPromptEvent is created, it already has a browser connection,
and does not need another asynchronous (and possibly racey) call to
establish full two-way communication with the browser process.

Several files in Blink's modules/app_banner directories that were solely
required for the AppBannerClient layer in chrome/renderer are deleted.
The existing layout tests are simplified by removing request_ids and
eliminating the AppBannerClient from ContentRendererClients. This
requires a dependency on content/public/common from
components/test_runner to allow a shim mojom::AppBannerService to be
injected.

dominickn@chromium.org is added to OWNERS for the Blink-side app
banner code.

BUG= 499704 , 655877 , 655902 

Review-Url: https://codereview.chromium.org/2393513004
Cr-Commit-Position: refs/heads/master@{#428238}
Commit  : 09f7b579849cc8725455d0468b03a0237a6b624d
Date    : Fri Oct 28 01:48:51 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@428126  1140286  6203.65  41  good
chromium@428182  1140586  6218.48  41  good
chromium@428210  1140053  6282.98  18  good
chromium@428224  1140053  6282.98  18  good
chromium@428231  1140053  6282.98  18  good
chromium@428235  1140053  6282.98  18  good
chromium@428237  1137050  5495.36  5   good
chromium@428238  1148245  7870.62  27  bad    <--

Bisect job ran on: android_nexus7_perf_bisect
Bug ID: 661515

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.intl.taobao.com.group.purchase.html memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/background/after_http_m_intl_taobao_com_group_purchase_html
Relative Change: 0.58%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3446
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997015219244977856


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5894742561259520

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment