New issue
Advanced search Search tips

Issue 661500 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in memory.top_10_mobile at 428225:428292

Project Member Reported by primiano@chromium.org, Nov 2 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=661500

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgo_zirgoM


Bot(s) for this bug's original alert(s):

android-nexus6
Cc: dominickn@chromium.org
Owner: dominickn@chromium.org

=== Auto-CCing suspected CL author dominickn@chromium.org ===

Hi dominickn@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Convert app banners to use Mojo.
Author  : dominickn
Commit description:
  
This CL converts the app banner system from Chrome IPC to Mojo and moves
all banner code from chrome/renderer to Blink. It also substantially
improves the layout test coverage for the BeforeInstallPromptEvent,
fixing various renderer crash bugs that are covered by the tests.

The key change is that the browser-side AppBannerManager makes a Mojo
request to Blink, which is intercepted by the WebLocalFrame and rerouted
to the AppBannerController. The AppBannerManager passes a bound
InterfaceRequest/Ptr in the Mojo request, which are used to create a
bound BeforeInstallPromptEvent. This ensures that when a
BeforeInstallPromptEvent is created, it already has a browser connection,
and does not need another asynchronous (and possibly racey) call to
establish full two-way communication with the browser process.

Several files in Blink's modules/app_banner directories that were solely
required for the AppBannerClient layer in chrome/renderer are deleted.
The existing layout tests are simplified by removing request_ids and
eliminating the AppBannerClient from ContentRendererClients. This
requires a dependency on content/public/common from
components/test_runner to allow a shim mojom::AppBannerService to be
injected.

dominickn@chromium.org is added to OWNERS for the Blink-side app
banner code.

BUG= 499704 , 655877 , 655902 

Review-Url: https://codereview.chromium.org/2393513004
Cr-Commit-Position: refs/heads/master@{#428238}
Commit  : 09f7b579849cc8725455d0468b03a0237a6b624d
Date    : Fri Oct 28 01:48:51 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@428224  1178112  7240.77  8  good
chromium@428233  1178112  7240.77  8  good
chromium@428237  1176371  1831.79  5  good
chromium@428238  1187840  0.0      5  bad    <--
chromium@428239  1187840  0.0      5  bad
chromium@428241  1190400  7240.77  8  bad
chromium@428258  1187840  0.0      8  bad
chromium@428292  1187840  0.0      8  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 661500

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:ashmem:proportional_resident_size_avg/background/after_http_www_baidu_com_s_word_google
Relative Change: 0.69%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2716
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997111157561661616


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5829690718158848

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: primiano@chromium.org
Status: WontFix (was: Untriaged)
few k of discardable memory aren't worth anybody's time.

Sign in to add a comment