New issue
Advanced search Search tips

Issue 661479 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

38.5% regression in blink_perf.canvas at 428405:428427

Project Member Reported by primiano@chromium.org, Nov 2 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=661479

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgg-acuQkM


Bot(s) for this bug's original alert(s):

android-nexus5X
Cc: ethannicholas@google.com
Owner: ethannicholas@google.com

=== Auto-CCing suspected CL author ethannicholas@google.com ===

Hi ethannicholas@google.com, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reduced skslc memory consumption
Author  : ethannicholas
Commit description:
  
The big change here is smarter generic type handling which allows us to
keep far fewer entries in the core symboltable. This also comments out
a number of OpenGL builtin functions which Skia does not use and is
unlikely to in the future.
BUG= 655673 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2442063002

Committed: https://skia.googlesource.com/skia/+/cffaa70896fa5bc6c7bf98abbaafb1a755b49762
Review-Url: https://codereview.chromium.org/2442063002
Commit  : 471e89405b71f04e07ae2887bde061185e262c81
Date    : Fri Oct 28 16:02:46 2016


===== TESTED REVISIONS =====
Revision                         Mean     Std Dev  N  Good?
chromium@428404                  2026.05  38.0964  8  good
chromium@428404,skia@55e0346f4b  2054.32  17.1259  5  good
chromium@428404,skia@471e89405b  1438.74  363.725  5  bad    <--
chromium@428405                  1298.93  234.988  4  bad
chromium@428406                  1274.07  131.614  5  bad
chromium@428407                  1405.89  209.298  5  bad
chromium@428410                  1337.67  295.508  5  bad
chromium@428416                  1370.34  333.393  8  bad
chromium@428427                  1373.95  273.348  8  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 661479

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.canvas
Test Metric: draw-video-to-hw-accelerated-canvas-2d/draw-video-to-hw-accelerated-canvas-2d
Relative Change: 32.33%
Score: 99.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/818
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997113512904119680


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5790367406882816

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Friendly perf-sheriff ping. Any update here Ethan?

Comment 5 by benhenry@google.com, Dec 20 2016

Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)
Looks like this benchmark had a huge improvement in June which overshadows the regression here.

Sign in to add a comment