Make video_WebRtc* site tests use media recorder instead of canvas snapshotting |
||||
Issue descriptionThe canvas snapshotting is based off javascript's setInterval, but there are no upper bounds on how long it can take to schedule the next run, so if the js main thread is busy the measurement becomes unreliable. We can try to fix this either with 1) a time-correcting loop (https://www.sitepoint.com/creating-accurate-timers-in-javascript/) 2) use mediarecorder I think the latter is more likely to deal robustly with media recording, and also relatively simple.
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cdcbd06acff04145c702a91527fcd9765d879973 commit cdcbd06acff04145c702a91527fcd9765d879973 Author: Patrik Höglund <phoglund@chromium.org> Date: Wed Nov 02 09:38:06 2016 Measure on the right video tag in WebRTC peerconnection test. Measuring on the local video preview, as was done before, doesn't make sense since the remote video is much more interesting here (also the local video is covered by video_WebRTCCamera). BUG=chromium:661472 TEST=locally on link laptop Change-Id: Iea22a99277d9c6ff6f7d128219206d2ede936d21 Reviewed-on: https://chromium-review.googlesource.com/406867 Commit-Ready: Patrik Höglund <phoglund@chromium.org> Tested-by: Rohit Makasana <rohitbm@chromium.org> Reviewed-by: Rohit Makasana <rohitbm@chromium.org> Reviewed-by: Vinayak Suley <vsuley@chromium.org> [modify] https://crrev.com/cdcbd06acff04145c702a91527fcd9765d879973/client/site_tests/video_WebRtcPeerConnectionWithCamera/loopback.html
,
Nov 29 2016
Edward, if you want you can do this one as an exercise in how to write site tests. I can help you set up the dev environment :)
,
Nov 29 2016
sgtm
,
Oct 30 2017
,
Oct 31 2017
Assigning to ehmaldonado@ as per #3 and #4
,
Jan 24 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rohi...@chromium.org
, Nov 2 2016