New issue
Advanced search Search tips

Issue 661461 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Should collect relevant GDI information on the dump in case of system misbehavior.

Reported by an...@yandex-team.ru, Nov 2 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

Steps to reproduce the problem:
Exhaust GDI resources somehow, e.g. open too many windows.

What is the expected behavior?
Browser crashes intentionally when faced with GDI problem.

What went wrong?
In case of crash it should collect relevant information on the dump and send it.

Did this work before? N/A 

Chrome version: 56.0.2908.0  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80e1d0d45fe77ad8ad61a9bff41e08a8bd147f9a

commit 80e1d0d45fe77ad8ad61a9bff41e08a8bd147f9a
Author: anpol <anpol@yandex-team.ru>
Date: Wed Nov 02 11:07:03 2016

Collect information on the dump when GetDC fails.

We already have the code that collects GDI usage information on the
dump, so we can reuse it to handle any unrecoverable GDI failures.

BUG= 661461 

Review-Url: https://codereview.chromium.org/2452933002
Cr-Commit-Position: refs/heads/master@{#429248}

[modify] https://crrev.com/80e1d0d45fe77ad8ad61a9bff41e08a8bd147f9a/base/debug/gdi_debug_util_win.cc
[modify] https://crrev.com/80e1d0d45fe77ad8ad61a9bff41e08a8bd147f9a/base/debug/gdi_debug_util_win.h
[modify] https://crrev.com/80e1d0d45fe77ad8ad61a9bff41e08a8bd147f9a/base/win/scoped_hdc.h
[modify] https://crrev.com/80e1d0d45fe77ad8ad61a9bff41e08a8bd147f9a/skia/ext/skia_utils_win.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9625fddb94caf89f7f967326bb662aced7b2d884

commit 9625fddb94caf89f7f967326bb662aced7b2d884
Author: anpol <anpol@yandex-team.ru>
Date: Sat Nov 05 09:56:20 2016

Collect total counters in case of GDI failure.

If a system instability is caused by some non-browser process, it will
be known from the total usage counters when crash dump is received.

Thus we can distinguish a case when some non-browser process is
misbehaving from other kinds of system resource exhaustion.

BUG= 661461 
R=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2467283002
Cr-Commit-Position: refs/heads/master@{#430161}

[modify] https://crrev.com/9625fddb94caf89f7f967326bb662aced7b2d884/base/debug/gdi_debug_util_win.cc

Labels: M-56
Cc: rbasuvula@chromium.org
Labels: TE-NeedsTriageHelp
This looks like out of scope for TE, hence adding the respective label for it to  triage further.

Thank You!
Status: Fixed (was: Unconfirmed)

Sign in to add a comment