Weifang, I have a question about the spec.

When save-as dialog opens, the file name text box has the initial focus.
After that, when we hit TAB key, which element should be focused?
File-type selector ("JPEG image" in the screen shot) or should we directly focus SAVE button?

I think it's more intuitive for the next TAB after the file name text box to be the "SAVE" button.

However, I think the confusion here is actually due to the placement of the File-type selector - Can you provide some background on what it's usage is? I wonder if we should be placing it to the left of the file name text box?

The file-type selector affects what type of files is displayed in the file list. (If "JPEG images" is selected, only JPEG images and folders will be shown in the file list. If "All files" is selected, all files will be shown)

When I save a file, sometimes I want to see all files to know more about where to save the file. But sometimes, I want to see only same-type files to find a file which I want to overwrite.

Adding sgabriel@ for UI input.

We do need to make the File-type selector accessible via TAB, but I strongly prefer the "SAVE" button to follow the file name text box.

Sebastien, what do you think of re-positioning the File-type selector to the left of the file name text box? We can then add it as a focus element after the "New Folder" button when tabbing and preserve the existing TAB behavior of file name text box -> SAVE.

I like the behavior described in #6. Let's do that :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49e876ae7c44c572607a55bdcc2ef8e992bb3f58

commit 49e876ae7c44c572607a55bdcc2ef8e992bb3f58
Author: tetsui <tetsui@google.com>
Date: Wed Apr 05 03:57:21 2017

Change the selectors position in Save as dialog and make it focusable.

BUG= 661460 
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2795953002
Cr-Commit-Position: refs/heads/master@{#461973}

[modify] https://crrev.com/49e876ae7c44c572607a55bdcc2ef8e992bb3f58/ui/file_manager/file_manager/foreground/css/file_manager.css
[modify] https://crrev.com/49e876ae7c44c572607a55bdcc2ef8e992bb3f58/ui/file_manager/file_manager/foreground/js/ui/location_line.js
[modify] https://crrev.com/49e876ae7c44c572607a55bdcc2ef8e992bb3f58/ui/file_manager/file_manager/foreground/js/ui/search_box.js
[modify] https://crrev.com/49e876ae7c44c572607a55bdcc2ef8e992bb3f58/ui/file_manager/file_manager/main.html

It's fixed by tetsui@'s change. Thanks!

9460.5.0 / 59.0.3071.15