New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661457 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[DIAL] Improve DialRegistry tests

Project Member Reported by imch...@chromium.org, Nov 2 2016

Issue description

To prevent issues like crbug.com/656073 from recurring we should have more comprehensive test cases. In particular, it's likely the bug would've been caught by ASAN bots if the TestDeviceExpires test case was modified to discover more than 1 devices.

 

Comment 1 by sko...@chromium.org, Nov 17 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8780ab5722f24aa3f463b2b5838b5ae229b3f946

commit 8780ab5722f24aa3f463b2b5838b5ae229b3f946
Author: imcheng <imcheng@chromium.org>
Date: Tue May 02 04:28:10 2017

[DIAL tests] Slightly improve DialRegistry tests.

Update the TestDeviceExpires test case with a slightly more complicated
scenario.

Also, to make the tests more robust, we will use a testing clock to
generate the base::Time for various objects. DialRegistry::Now() is
replaced with a clock that can be swapped out in tests.

BUG= 661457 

Review-Url: https://codereview.chromium.org/2843653002
Cr-Commit-Position: refs/heads/master@{#468556}

[modify] https://crrev.com/8780ab5722f24aa3f463b2b5838b5ae229b3f946/chrome/browser/media/router/discovery/dial/dial_registry.cc
[modify] https://crrev.com/8780ab5722f24aa3f463b2b5838b5ae229b3f946/chrome/browser/media/router/discovery/dial/dial_registry.h
[modify] https://crrev.com/8780ab5722f24aa3f463b2b5838b5ae229b3f946/chrome/browser/media/router/discovery/dial/dial_registry_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment