New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661441 link

Starred by 1 user
Status: Fixed
Owner:
wychen@chromium.org
Closed: Nov 2016
Cc:
█ aa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 661401



Sign in to add a comment

UMA Extensions.OffStoreInstallDecisionHard enum masked

Project Member Reported by wychen@chromium.org, Nov 2 2016 
In this code snippet, OffStoreInstallDisallowed should be OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2. However, it is resolved to be OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0. This caused wrong bucket assignment.

https://cs.chromium.org/chromium/src/chrome/browser/extensions/crx_installer.cc?rcl=1478028288&l=352

        UMA_HISTOGRAM_ENUMERATION(kHistogramName, OffStoreInstallDisallowed,
                                  NumOffStoreInstallDecision);


"Extensions.OffStoreInstallDecisionHard" is not defined in histograms.xml, and is introduced in 2012, so this might not be very relevant now.

This is discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f902f2c3194edaffd899ca7a5a9689d2b71568da

commit f902f2c3194edaffd899ca7a5a9689d2b71568da
Author: wychen <wychen@chromium.org>
Date: Wed Nov 02 22:33:33 2016

Fix enum in UMA Extensions.OffStoreInstallDecisionHard

OffStoreInstallDisallowed should be
OffStoreInstallDecision::OffStoreInstallDisallowed, which is 2.
However, it is resolved to be
OffStoreInstallAllowReason::OffStoreInstallDisallowed, which is 0.
This caused wrong bucket assignment.

This was discovered by the checks implemented in this CL:
https://codereview.chromium.org/2469993002/

BUG= 661441 

Review-Url: https://codereview.chromium.org/2469193002
Cr-Commit-Position: refs/heads/master@{#429424}

[modify] https://crrev.com/f902f2c3194edaffd899ca7a5a9689d2b71568da/chrome/browser/extensions/crx_installer.cc

Comment 2 by wychen@chromium.org, Nov 2 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment