New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661395 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Have a script to run test harness easily

Project Member Reported by romax@chromium.org, Nov 2 2016

Issue description

Have a test which will make test harness easy to use and can pass in arguments.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f3c7214424f1dab63e6d773feaf371457d7fafd

commit 4f3c7214424f1dab63e6d773feaf371457d7fafd
Author: romax <romax@chromium.org>
Date: Fri Nov 04 20:19:46 2016

[Offline Pages] Script for running evaluation tests.

Added the functionality to the evaluation test to parse config file and
read the parameters. Also have a script which would allow user to run
the test harness more easily.

BUG= 661395 

Review-Url: https://codereview.chromium.org/2465303003
Cr-Commit-Position: refs/heads/master@{#429996}

[modify] https://crrev.com/4f3c7214424f1dab63e6d773feaf371457d7fafd/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
[add] https://crrev.com/4f3c7214424f1dab63e6d773feaf371457d7fafd/chrome/browser/android/offline_pages/evaluation/run_offline_page_evaluation_test.py

Comment 2 by romax@chromium.org, Nov 4 2016

Status: Fixed (was: Started)

Comment 3 by romax@chromium.org, Nov 8 2016

Status: Assigned (was: Fixed)
Need to provide an option to run on unrooted-devices rather than fail.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82b22f4df42550e6614719076463ceea50dcfa09

commit 82b22f4df42550e6614719076463ceea50dcfa09
Author: romax <romax@chromium.org>
Date: Sat Nov 12 02:01:03 2016

[Offline Pages] Root access no more required by test harness.

Making root access unnecessary by adding a step which would copy saved
offline pages to external storage after test finishes. So that unrooted
devices can run the test harness script.
Also added an option to select which device to use when more than one
devices are connected.

BUG= 661395 

Review-Url: https://codereview.chromium.org/2493673003
Cr-Commit-Position: refs/heads/master@{#431739}

[modify] https://crrev.com/82b22f4df42550e6614719076463ceea50dcfa09/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
[modify] https://crrev.com/82b22f4df42550e6614719076463ceea50dcfa09/chrome/browser/android/offline_pages/evaluation/run_offline_page_evaluation_test.py

Comment 5 by romax@chromium.org, Nov 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment