Issue 661392 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	chaopeng@chromium.org
Closed:	Nov 2016
Components:	UI>Shell
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome
Pri:	1
Type:	Bug
Hotlist-Input-Dev

Find "scrollbar tickmarks" don't display with Aura overlay scrollbars

Project Member Reported by bokan@chromium.org, Nov 2 2016

Issue description

What steps will reproduce the problem?
(0) Enable chrome://flags/#overlay-scrollbars
(1) Go to https://en.wikipedia.org/wiki/Cat
(2) Search for "fur"

What is the expected output?
We should show little yellow tick marks on the scrollbar (and perhaps force the scrollbar to visible until the find box is dismissed)

What do you see instead?
Nothing

Comment 1 by chaopeng@chromium.org, Nov 4 2016

Status: Started (was: Assigned)

screenshot for the patch.

	fade-in.png 187 KB View Download

	fade-out.png 195 KB View Download

	mouse-over-scrollbar.png 187 KB View Download

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bafa9a4a5a355f516d15f09d67fea74c91c3c42b

commit bafa9a4a5a355f516d15f09d67fea74c91c3c42b
Author: chaopeng <chaopeng@chromium.org>
Date: Wed Nov 16 16:42:30 2016

add Tickmarks to aura overlay scrollbar

In this patch, I reuse the paintTickmarks implement in ScrollbarThemeAura.
It has same behavier with Tickmarks in ScrollbarThemeMac.

BUG= 661392 

Review-Url: https://codereview.chromium.org/2478743003
Cr-Commit-Position: refs/heads/master@{#432516}

[modify] https://crrev.com/bafa9a4a5a355f516d15f09d67fea74c91c3c42b/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp
[modify] https://crrev.com/bafa9a4a5a355f516d15f09d67fea74c91c3c42b/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h
[modify] https://crrev.com/bafa9a4a5a355f516d15f09d67fea74c91c3c42b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp
[modify] https://crrev.com/bafa9a4a5a355f516d15f09d67fea74c91c3c42b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h
[modify] https://crrev.com/bafa9a4a5a355f516d15f09d67fea74c91c3c42b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.h
[modify] https://crrev.com/bafa9a4a5a355f516d15f09d67fea74c91c3c42b/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

Comment 3 by chaopeng@chromium.org, Nov 17 2016

Status: Fixed (was: Started)

Comment 4 by rookrishna@chromium.org, Mar 31 2017

Status: Verified (was: Fixed)

►

Issue 661392 link

Issue metadata

Find "scrollbar tickmarks" don't display with Aura overlay scrollbars

Issue description

Comment 1 by chaopeng@chromium.org, Nov 4 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Nov 16 2016

Comment 2 Deleted

Comment 3 by chaopeng@chromium.org, Nov 17 2016

Comment 3 Deleted

Comment 4 by rookrishna@chromium.org, Mar 31 2017

Comment 4 Deleted

Sign in to add a comment