Search in Launcher shows empty apps box when no apps results found |
||||||||||
Issue descriptionChrome Version : 54.0.2840.79 OS Version: 8743.76.0 Repro 1) Open Launcher 2) Type search query into searchbox 3) Keep typing until there are no app matches Expected When no matches are found, do not show apps result box Actual It shows an empty apps box at the bottom. See screenshot
,
Nov 3 2016
Bisect: You are probably looking for a change made after 407077 (known good), but no later than 407078 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/d8a924a2dd4693f40a27b33efc2de3db46a2496e..e9b526245329d9f5106ddcf9c7791a17b2d0650b Looks like it was https://codereview.chromium.org/2165483002. The problem was switching from BoxLayout to GridLayout, at least as implemented. The BoxLayout would hide itself when empty; the GridLayout doesn't.
,
Nov 3 2016
In the aforementioned CL, the Launcher's app search results box was switched from using BoxLayout to GridLayout. This was apparently for aesthetic reasons, but things seem fine now with the old BoxLayout. I'm attaching screenshots of the box with both layout managers (BoxLayout from my proposed CL (https://codereview.chromium.org/2473033002) and GridLayout from the current code). The icon placement is identical; the only difference is space allowed for app names, and I'd say that BoxLayout is actually better as the text doesn't go right to the edge of the box. I tried this with 2, 4, 7, and 8 results, and in all cases, icon placement was identical.
,
Nov 4 2016
Looks good, but how about selection? Did it change? If yes, then could you provide a screenshot? Thanks!
,
Nov 16 2016
Selection behaves identically, as far as I can tell, and looks *almost* the same. I've attached screenshots of Box and Grid layouts, with one item selected, and the next hover-highlighted. When BoxLayout is used, there is 1px of whitespace between selection box and edge of container, and 2px of whitespace between selection and hover boxes; when GridLayout is used, there is no whitespace. The 1 or 2px whitespace padding maybe looks a little worse, but I think that's offset by the text not running right up to the edge. A tossup in my opinion.
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32247f5271fd583a683bc8dc2e4c07ce3cf72b85 commit 32247f5271fd583a683bc8dc2e4c07ce3cf72b85 Author: glevin <glevin@chromium.org> Date: Mon Nov 21 23:19:06 2016 Hide Launcher app search box when empty BUG= 661380 TEST=Open launcher, type a search that returns no app results. The horizontal box that usually contains app results should be hidden. Review-Url: https://codereview.chromium.org/2473033002 Cr-Commit-Position: refs/heads/master@{#433686} [modify] https://crrev.com/32247f5271fd583a683bc8dc2e4c07ce3cf72b85/ui/app_list/views/search_result_tile_item_list_view.cc
,
Nov 21 2016
,
Nov 22 2016
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.
,
Nov 22 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 28 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/956718c5d2933fdc7cd6df90339565aa647e3213 commit 956718c5d2933fdc7cd6df90339565aa647e3213 Author: glevin <glevin@chromium.org> Date: Mon Nov 28 23:56:31 2016 Hide Launcher app search box when empty BUG= 661380 TEST=Open launcher, type a search that returns no app results. The horizontal box that usually contains app results should be hidden. Review-Url: https://codereview.chromium.org/2473033002 Cr-Commit-Position: refs/heads/master@{#433686} (cherry picked from commit 32247f5271fd583a683bc8dc2e4c07ce3cf72b85) Review URL: https://codereview.chromium.org/2534043002 . Cr-Commit-Position: refs/branch-heads/2883@{#672} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/956718c5d2933fdc7cd6df90339565aa647e3213/ui/app_list/views/search_result_tile_item_list_view.cc
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd7b6ddecbf986fa18f8f6290c7ab700cbc6e5a1 commit dd7b6ddecbf986fa18f8f6290c7ab700cbc6e5a1 Author: glevin <glevin@chromium.org> Date: Tue Nov 29 00:26:52 2016 Hide Launcher app search box when empty BUG= 661380 TEST=Open launcher, type a search that returns no app results. The horizontal box that usually contains app results should be hidden. Review-Url: https://codereview.chromium.org/2473033002 Cr-Commit-Position: refs/heads/master@{#433686} (cherry picked from commit 32247f5271fd583a683bc8dc2e4c07ce3cf72b85) Review URL: https://codereview.chromium.org/2536053002 . Cr-Commit-Position: refs/branch-heads/2924@{#144} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/dd7b6ddecbf986fa18f8f6290c7ab700cbc6e5a1/ui/app_list/views/search_result_tile_item_list_view.cc
,
Dec 3 2016
,
Dec 6 2016
Verified on ChromeOS 8872.65.0, 55.0.2883.76 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by glevin@chromium.org
, Nov 2 2016Owner: glevin@chromium.org
Status: Started (was: Assigned)