New issue
Advanced search Search tips

Issue 661375 link

Starred by 3 users

Issue metadata

Status: Fixed
Merged: issue 659109
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Typing the spacebar does nothing in a cell with a <BR> tag in a table in a CONTENTEDITABLE div

Reported by mike.phe...@ephox.com, Nov 2 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

Steps to reproduce the problem:
See attached file:

1. Click into the cell.
2. Type 'a' and then tap the space bar multiple times.
3. Type 'a' and the space bar again.

What is the expected behavior?
The 'a' appears then the cursor advances space-by-space, the second 'a' appears and more spaces.

What went wrong?
- The 'a' appears then nothing happens when the space bar is tapped. The second 'a' appears, and nothing happens when the space bar is tapped.
- The space character is 'lost'

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 54.0.2840.71 (Official Build) m (64-bit)  Channel: n/a
OS Version: Windows 10 Home 14393.351
Flash Version:
 
bug_chrome_contenteditable.html
917 bytes View Download

Comment 1 by yosin@chromium.org, Nov 2 2016

Mergedinto: 659109
Status: Duplicate (was: Unconfirmed)
Status: Available (was: Duplicate)
Un-dupe per  issue 659109  comments
jsfiddle copy of the replication case:
https://jsfiddle.net/x943naf6/6/
Owner: joone....@intel.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b9a9a6f8c9c646ac542a9e1a2f18c59140849e6

commit 5b9a9a6f8c9c646ac542a9e1a2f18c59140849e6
Author: joone.hur <joone.hur@intel.com>
Date: Thu Feb 09 10:04:41 2017

Check if the next text node has a leading white space

In the previous CL(https://crrev.com/2432083003), we only checked
the leading space of the next text node, but we need to check all kinds
of white space including enter.

BUG= 661375 
TEST=editing/inserting/insert-space.html

Review-Url: https://codereview.chromium.org/2684973005
Cr-Commit-Position: refs/heads/master@{#449251}

[modify] https://crrev.com/5b9a9a6f8c9c646ac542a9e1a2f18c59140849e6/third_party/WebKit/LayoutTests/editing/inserting/insert-space.html
[modify] https://crrev.com/5b9a9a6f8c9c646ac542a9e1a2f18c59140849e6/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Comment 6 by joone....@intel.com, Feb 10 2017

Status: Fixed (was: Started)
Thanks! What version will that be released in?

Comment 8 by phistuck@gmail.com, Feb 10 2017

#7 - Chrome 58.
That's still a couple of months away, isn't it? Similar to what happened with  issue 659109 , where this is a regression in Chrome 54, could this be please be moved up to release in 57?

Sign in to add a comment