[Regression] AppRTC Audio receiving codec is not displayed in stats window and chrome://webrtc-internals |
||||
Issue descriptionChrome Version: 56.0.2905.0 / 8953.0.0 dev What steps will reproduce the problem? 1. Browse to https://appr.tc/?debug=loopback 2. Listen for audio disruptions and watch for video stutter 3. Press "i" to open up the stats data, while in the call (alternatively, expand the ssrc_<>_send in chrome://webrtc-internals) Expected result: a) Audio and video quality should be good b) In the apprtc call stats window, Audio Rx and Audio Tx should show "Opus" (also in ssrc_<>_recv in chrome://webrtc-internals) Actual result: a) Audio and video quality is good b) In the apprtc call stats window, Audio Rx is empty and Audio Tx shows "Opus" (also in ssrc_<>_recv in chrome://webrtc-internals) Notes: 1. This issue is not observed on chrome OS with M55 55.0.2883.33 / 8872.31.0 beta 2. This issue is also observed with apprtc peer2peer back calls 3. Feedback submitted for this issue: https://feedback.corp.google.com/product/208/neutron?lView=rd&lRSort=1&lROrder=2&lRFilter=1&lReportSearch=user:srcv&lReport=15070068733
,
Nov 1 2016
WebRTC internal dump and js logs for apprtc loopback calls from chrome device Peppy: https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/661632/
,
Nov 1 2016
Bisect info - You are probably looking for a change made after 427623 (known good), but no later than 427633 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/802c2138162919a3602f4eb20feb3e4020b81438..02a3e9549a9be351eb995a6e69ef949d60674900
,
Nov 2 2016
srcv@ just to confirm, you can still hear the incoming audio even when the receive codec is empty? What happens if you try to add arc=opus/48000 and/or asc=opus/48000 as a URL param? If that does not work, what about ISAC/16000?
,
Nov 2 2016
Will try to reproduce and bisect, so that I know who to assign this to.
,
Nov 2 2016
The error was introduces in one of these WebRTC commits: [bad] a6b8298b48ad0 Use relative names in GN to make Chromium happy [skip] 4a18f16c62975 Update XServerPixelBuffer to handle errors returned from XGetImage(). [skip] da2bf4e150a1b Stop using old AudioCodingModule::RegisterReceiveCodec overloads The two first don't build in Chromium. Makes sense, since the third (the bad one) is a build fix for the first one. Conclusion: WebRTC commit da2bf4e150a1b is to blame. I'll assign this bug to the deplorable individual who wrote it, and then my work here is done.
,
Nov 2 2016
jansson@: Yes. Receiving audio can be heard during apprtc calls. Only Audio receiving codec is displayed empty. Tried adding arc=opus/48000 and/or asc=opus/48000 and ISAC/16000 to the apprtc URL parameters as follows. Audio receiving codec is still not displayed. https://appr.tc/?debug=loopback&arc=opus/48000 https://appr.tc/?debug=loopback&asc=opus/48000&arc=opus/48000 https://appr.tc/?debug=loopback&asc=opus/48000 https://appr.tc/?debug=loopback&arc=ISAC/16000 https://appr.tc/?debug=loopback&asc=ISAC/16000
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/e941306bd66883266bc0e51baefad6ab25142fd6 commit e941306bd66883266bc0e51baefad6ab25142fd6 Author: kwiberg <kwiberg@webrtc.org> Date: Thu Nov 03 12:29:05 2016 NetEq: Don't forget to save the codec name BUG= chromium:661362 Review-Url: https://codereview.webrtc.org/2472083002 Cr-Commit-Position: refs/heads/master@{#14909} [modify] https://crrev.com/e941306bd66883266bc0e51baefad6ab25142fd6/webrtc/modules/audio_coding/neteq/decoder_database.cc [modify] https://crrev.com/e941306bd66883266bc0e51baefad6ab25142fd6/webrtc/modules/audio_coding/neteq/decoder_database.h [modify] https://crrev.com/e941306bd66883266bc0e51baefad6ab25142fd6/webrtc/modules/audio_coding/neteq/decoder_database_unittest.cc [modify] https://crrev.com/e941306bd66883266bc0e51baefad6ab25142fd6/webrtc/modules/audio_coding/neteq/neteq_impl.cc
,
Nov 3 2016
The CL in comment #8 fixes the problem when I try it locally.
,
Nov 7 2016
Verified in M56 Canary 56.0.2912.0 in Win, Mac, Linux Audio Rx now shows the correct entries in both the apprtc call overlay as well as in chrome://webrtc-internals Will close as 'Verified' after srcv@ verifies in CrOS
,
Nov 7 2016
Verified that appRTC audio receiving codec is displayed in stats window and chrome://webrtc-internals on Chrome OS with M56 56.0.2910.0 / 8968.0.0 dev
,
Nov 8 2016
Thanks, both of you! |
||||
►
Sign in to add a comment |
||||
Comment 1 by srnarayanan@chromium.org
, Nov 1 2016