New issue
Advanced search Search tips

Issue 661359 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Chrome is not good at navigating to fragment links in documents with custom elements.

Project Member Reported by malteubl@google.com, Nov 1 2016

Issue description

Version: All
OS: All except iOS

What steps will reproduce the problem?
(1) Go to https://www.ampproject.org/learn/who/#analytics
(2) Possibly try again, since it is a race condition. For me it only repros on new tabs, never on reload

What is the expected output?

The document should scroll the Analytics paragraph into view.

What do you see instead?

Sometime Chrome scrolls to a random other place in the doc.
Safari never gets it wrong.
I think Chrome should figure out the element to scroll into view and then use scroll anchoring to keep it in view for a short time after page load.

 
Cc: -skobes@chromium.org
Owner: skobes@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c73e92a39a2e894b32a318900d0730f8ae7b68e

commit 1c73e92a39a2e894b32a318900d0730f8ae7b68e
Author: skobes <skobes@chromium.org>
Date: Thu Nov 03 14:47:42 2016

Clamping shouldn't clear the fragment anchor.

Also rename fragment anchor tests for clarity.

BUG= 661359 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2474813002
Cr-Commit-Position: refs/heads/master@{#429581}

[add] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/LayoutTests/fast/loader/clamping-preserves-fragment-anchor.html
[rename] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load-expected.txt
[rename] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load-when-hidden-expected.txt
[rename] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load-when-hidden.html
[rename] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/LayoutTests/fast/loader/fragment-anchor-cleared-after-load.html
[modify] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/1c73e92a39a2e894b32a318900d0730f8ae7b68e/third_party/WebKit/Source/platform/scroll/ScrollTypes.h

Status: Fixed (was: Started)
Fixed in canary (56.0.2909.0).
Thanks for the ultra quick fix. Tested in canary and it is rock solid now!

Sign in to add a comment