DCHECK when selecting the bottommost voice search language in settings |
||||||||
Issue description
Open up voice search settings and scroll to the bottom of the list. On tapping the bottommost item, you'll hit:
DCHECK_LT(static_cast<size_t>(index),
localeConfig->GetAvailableLocales().size());
,
Nov 1 2016
An alternative fix would be to create a separate item type for DefaultLanguageOption (vs LanguageOption). Then we could handle that separately based on item type, rather than checking index == 0.
,
Nov 2 2016
Oh whoops, good catch. I like the new item type approach the best, but I'm okay if you just update the DCHECK to (index - 1) to keep changes minimal.
,
Nov 21 2016
Friendly ping on this blocker for the current release.
,
Nov 22 2016
Is someone fixing this? Rohit? Kurt? Sounds like it should be fixed. It's a DCHECK, so won't affect release builds. Does this really need to be a ReleaseBlock-Stable?
,
Nov 22 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3746bdbc5b5d232fb2e0b81a5a1c150d4ffaa280 commit 3746bdbc5b5d232fb2e0b81a5a1c150d4ffaa280 Author: rohitrao <rohitrao@google.com> Date: Tue Nov 22 21:15:02 2016
,
Nov 22 2016
,
Nov 22 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/3746bdbc5b5d232fb2e0b81a5a1c150d4ffaa280 commit 3746bdbc5b5d232fb2e0b81a5a1c150d4ffaa280 Author: rohitrao <rohitrao@google.com> Date: Tue Nov 22 21:15:02 2016
,
Nov 22 2016
[Automated comment] Less than 2 weeks to go before AppStore submit on M55, manual review required.
,
Nov 23 2016
,
Nov 23 2016
Also needs to be on M56.
,
Nov 23 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 23 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bc88874acf1ad47ec7fadceb34aff288916ba942 commit bc88874acf1ad47ec7fadceb34aff288916ba942 Author: rohitrao <rohitrao@google.com> Date: Tue Nov 22 21:15:02 2016
,
Nov 23 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bc88874acf1ad47ec7fadceb34aff288916ba942 commit bc88874acf1ad47ec7fadceb34aff288916ba942 Author: rohitrao <rohitrao@google.com> Date: Tue Nov 22 21:15:02 2016
,
Nov 30 2016
Moving out of 55 because I'm having trouble cherry-picking and it's only a DCHECK, so it won't affect production builds. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rohitrao@chromium.org
, Nov 1 2016