Implement UI recommandation for dropdowns in Payment Request. |
||||||||||||||||||||||
Issue descriptionThey should follow these guidelines: go/list-dropdown
,
Dec 20 2016
Here are the screenshots, note that, I only padded for billing address dropdown (8dp top and bottom).
,
Dec 20 2016
,
Dec 20 2016
hwi@: Please take a look at the UI.
,
Dec 20 2016
LGTM - Thanks gogerald@!
,
Dec 21 2016
+ianwen to see the table screenshots.
,
Jan 4 2017
Find a problem when making the recommendation dropdown box match the width of the field according to the mocks. The selected text overlaps the arrow in the field (this could happen when the length of the recommendation is long enough without starting a new line), check the first screenshot. If we use default padding (do not set padding 0 explicitly), then there is no overlap, but the width of the dropdown box is not exactly match the width of the field (check the rest of the screenshots). Personally, I think 'using default padding' is better,
,
Jan 4 2017
Can you change the padding depending on whether the dropdown is open or closed?
,
Jan 4 2017
Not sure that's the right thing to do. Use default padding on Spinner looks good to me, the user can see the triangle icon and know it is a dropdown field. To make the dropdown width exactly match the width of the field, I could either pad Spinner according to dropdown status dynamically or the text. Padding the Spinner dynamically is tricky since there is no simple way to monitor the dropdown status. Padding the text is simple. Below first screenshot is the result of padding 24dp at the end of the text. It shows the maximum length of the text can go in one line.
,
Jan 4 2017
Do your best and submit the patch for review.
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05265d26d330f8d8331ce624cce2a9c4a0cd616d commit 05265d26d330f8d8331ce624cce2a9c4a0cd616d Author: gogerald <gogerald@chromium.org> Date: Wed Jan 04 22:06:10 2017 Update billing address dropdown style to match the design BUG= 661357 Review-Url: https://codereview.chromium.org/2592733002 Cr-Commit-Position: refs/heads/master@{#441480} [modify] https://crrev.com/05265d26d330f8d8331ce624cce2a9c4a0cd616d/chrome/android/java/res/layout/multiline_spinner_item.xml [add] https://crrev.com/05265d26d330f8d8331ce624cce2a9c4a0cd616d/chrome/android/java/res/layout/payment_request_dropdown_item.xml [modify] https://crrev.com/05265d26d330f8d8331ce624cce2a9c4a0cd616d/chrome/android/java/res/layout/payment_request_editor_dropdown.xml [modify] https://crrev.com/05265d26d330f8d8331ce624cce2a9c4a0cd616d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/BillingAddressAdapter.java [modify] https://crrev.com/05265d26d330f8d8331ce624cce2a9c4a0cd616d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
,
Jan 5 2017
,
Jun 27 2017
|
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by gogerald@chromium.org
, Dec 19 2016