New issue
Advanced search Search tips

Issue 661344 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 653916



Sign in to add a comment

Remove BrowserThread::UnsafeGetMessageLoopForThread()

Project Member Reported by gab@chromium.org, Nov 1 2016

Issue description

This is a very old API. It doesn't make much sense after the recent removal of many long-deprecated MessageLoop methods and it can't be supported in the TaskScheduler redirection.
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1

commit 143ea62ac9c872d88399ba2c7a81d3aa1f889fc1
Author: gab <gab@chromium.org>
Date: Thu Nov 03 12:47:00 2016

Replace URLDataSource::MessageLoopForRequestPath() with TaskRunnerForRequestPath().

This is inline with ongoing work to generalize MessageLoop usage towards TaskRunners.

BUG= 661344 

Review-Url: https://codereview.chromium.org/2476433002
Cr-Commit-Position: refs/heads/master@{#429545}

[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/chrome/browser/search/suggestions/suggestions_ui.cc
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/chrome/browser/search/thumbnail_source.cc
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/chrome/browser/search/thumbnail_source.h
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/chrome/browser/thumbnails/thumbnail_list_source.cc
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/chrome/browser/thumbnails/thumbnail_list_source.h
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/chrome/browser/ui/webui/theme_source.cc
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/chrome/browser/ui/webui/theme_source.h
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/content/browser/webui/shared_resources_data_source.cc
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/content/browser/webui/shared_resources_data_source.h
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/content/browser/webui/url_data_manager_backend.cc
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/content/public/browser/url_data_source.cc
[modify] https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1/content/public/browser/url_data_source.h

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeb8129a0f5c3829193312fed52595ffde9b7c8a

commit aeb8129a0f5c3829193312fed52595ffde9b7c8a
Author: gab <gab@chromium.org>
Date: Fri Nov 04 02:55:26 2016

Remove BrowserThread::UnsafeGetMessageLoopForThread()

Replacing one weird MessageLoop::IsIdleForTesting() loop in
chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
with content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

And all other use cases by BrowserThread::GetTaskRunnerForThread().

BUG= 661344 

Review-Url: https://codereview.chromium.org/2473823002
Cr-Commit-Position: refs/heads/master@{#429774}

[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/content/browser/browser_main_loop.cc
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/content/browser/browser_thread_impl.cc
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/content/public/browser/browser_thread.h
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/ios/web/public/web_thread.h
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/ios/web/web_thread_impl.cc
[modify] https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a/ios/web/webui/url_data_manager_ios_backend.mm

Comment 4 by gab@chromium.org, Nov 7 2016

Components: Internals>TaskScheduler

Comment 5 by gab@chromium.org, Nov 8 2016

Status: Fixed (was: Started)

Sign in to add a comment