My position is that it's WAI. I'd agree it's more tedious, but I don't think it's un-usable or a dev blocker.

Not a dev blocker does not equal WAI. Are we planning to fix this after launching to Dev?

Just throwing some thoughts out there - how about adding a text input on the top as filter, and add a comma-separated list on the bottom showing currently selected languages?

FYI https://codereview.chromium.org/2519853005.

I believe our original mocks had a searchbox and that got dropped at some point. Seems worth offering since the list is pretty long. Keeping as a P2.

@tbuckley, bettes: Are there mocks for this (or are there going to be)? Asking because an external contributor has sent me a CL about this (as mentioned in #6 above).

See attached screencast on how their implementation looks like. The dialog changes size and jumps around while the user is typing, which I find problematic.

Deleted: filter_languages.mp4 228 KB

	filter_languages.mp4 228 KB View Download

It looks like the search feature was dropped when we moved to the new dialog: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Language-1.png%3Fz=width

There is however a spec for the searchbox: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_search.png%3Fz=width

The spec assumes there's a header row the search box can go in, which doesn't seem to be the case with this dialog. The current location at the top of the list seems reasonable to me.

There are some details where it's off from the spec (I think the underline color, missing placeholder text, missing a clear button, etc). I also think the dialog height should remain fixed.

dpapad@: can haz bottom-border for now, maybe?

longer term: let's make a search box or something, but there's still things to figure out (should we hide checked languages while filtering?)

this surely is a pain, so i guess we should try

@dbeam, @tbuckley, @bettes: Here is my proposal for the search UI (see screencast). Besides the search box, there is also an area at the bottom of the dialog displaying the currently selected languages. Without showing currently selected languages, the user does not really know what they are "OKing" when the click the action button.
WDYT?

Re-attaching video.

Deleted: search_languages_proposal.mp4 417 KB

	search_languages_proposal.mp4 417 KB View Download

we could also just "freeze" the checkboxes that are selected on the top, in a separate list

ok, so let's say there's only 3 languages:

  Search: ____
  [ ] English
  [ ] German
  [ ] Spanish

if the user searches for 'e', then

  Search: _e__
  [ ] English
  [ ] German

is showing, when checking [x] English, now it shows up like

  Search: _e__
  [x] German
  ------------
  [ ] English

if search is cleared

  Search: ____
  [x] German
  ------------
  [ ] English
  [ ] Spanish

or something like this.  unchecking German would move it back into the unchecked list:

  Search: ____
  [ ] English
  [ ] German
  [ ] Spanish

Since this dialog is only for adding languages (users remove languages via the 3-dot menu), I don't think it's as important to show users all of the selected items even when the list is filtered. We don't expect users to spend so long in this dialog that they forget what they selected.

I think the search box just needs the correct focus underline color and a clear button.

@tbuckley: Updated my CL based on your feedback. Can you please take a look at the visual outcome (focus underline and clear button should be fixed now).

Deleted: language_search.mp4 242 KB

	language_search.mp4 242 KB View Download

the video seems fine even if the UI is a little rough.

that's cool with me and I'm fine with not showing which are selected other than when submitting.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390

commit 9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390
Author: dpapad <dpapad@chromium.org>
Date: Fri Mar 24 02:03:39 2017

MD Settings: Allow searching the languages list in "add language" dialog.

BUG= 661342 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2772873002
Cr-Commit-Position: refs/heads/master@{#459338}

[modify] https://crrev.com/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390/chrome/browser/resources/settings/languages_page/add_languages_dialog.js
[modify] https://crrev.com/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390/chrome/browser/resources/settings/settings_page/settings_subpage_search.js
[modify] https://crrev.com/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/9493bb90ea9b5cc4c5e91c388912d2cdc0cf7390/chrome/test/data/webui/settings/settings_subpage_test.js

Verified this issue on windows 10, Mac 10.12.3, and Ubuntu 14.04 using chrome version #59.0.3053.3
Observed there is search option for adding languages in "chrome://settings --> Add Languages"
Hence adding TE-Verified labels.
Please find the attached screen-cast for the reference.


Thanks!!

Deleted: Issue 661342.mp4 450 KB

	Issue 661342.mp4 450 KB View Download