PIN quick unlock: Pinpad input is not displayed after a character is typed. |
||||
Issue descriptionGoogle Chrome 56.0.2905.0 (Official Build) dev (64-bit) Revision 0 Platform 8953.0.0 (Official Build) dev-channel samus What steps will reproduce the problem? 1. Settings -> Click on 'Manage Screen lock' 2. Click on 'Change PIN' 3. Enter a digit by clicking on pin pad 4. Type in any character from keyboard 5. Previously entered digits are cleared 6. Now, click on numbers on pinpad What do you see? Numbers are not accepted. Type in numbers/characters from keyboard. They are not displayed on the screen.
,
Nov 2 2016
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/344b6d2380dbbf312a4725c308eb0cd4d0627177 commit 344b6d2380dbbf312a4725c308eb0cd4d0627177 Author: sammiequon <sammiequon@chromium.org> Date: Sat Nov 12 04:37:45 2016 cros: Allow pin keyboard to keep focus without popping up the pin keyboard. We want each button click to transfer focus back to the pin keyboard, but this not work well with virtual keyboard. Previously kept focus on the buttons, but added key events to each button so they users can still use the keyboard after pressing a keyboard. This CL tries another method by preventing the virtual keyboard from popping up on button clicks. Since I was working on the PIN, I changed the input back to type text which fixes the bug with the caret jumping around when non-numerical input is entered. BUG= 653297 , 653642 , 661334 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2444443002 Cr-Commit-Position: refs/heads/master@{#431769} [modify] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js [modify] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h [modify] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/ui/keyboard/BUILD.gn [modify] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/ui/keyboard/keyboard_util.cc [add] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/ui/keyboard/scoped_keyboard_disabler.cc [add] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/ui/keyboard/scoped_keyboard_disabler.h [modify] https://crrev.com/344b6d2380dbbf312a4725c308eb0cd4d0627177/ui/login/account_picker/user_pod_row.js
,
Nov 23 2016
,
Nov 28 2016
Verified on ChromeOS 9000.8.0, 56.0.2924.7 |
||||
►
Sign in to add a comment |
||||
Comment 1 by dhadd...@chromium.org
, Nov 1 2016