New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661333 link

Starred by 1 user
Status: Fixed
Owner:
█ jcivelli@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

GpuSurfaceLookup DCHECK

Project Member Reported by jcivelli@chromium.org, Nov 1 2016 
GpuSurfaceTracker is compiled as part of a source_set included by content (and soon other components) and it extends a class (GpuSurfaceLookup) which is part of the gpu component.
This can causes several instances of the GpuSurfaceTracke singleton to be caused (which is wrong) inheriting from the same GpuSurfaceLookup instance which DCHECKs.

GpuSurfaceTracker should probably be part of the gpu component.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0ce0067c0be88ae92e126e06c9421894a3ae3ef

commit b0ce0067c0be88ae92e126e06c9421894a3ae3ef
Author: jcivelli <jcivelli@chromium.org>
Date: Wed Nov 02 18:44:07 2016

GpuSurfaceTracker should not be a source set other components depend on.
As it is today, different components depending on it would end up with
multiple instances of the GpuSurfaceTracker singleton.
GpuSurfaceTracker inherits from GpuSurfaceLookup for which there is only
one instance (part of the gpu component), causing a DCHECK.
This CL moves the GpuSurfaceTracker to the gpu component like
GpuSurfaceLookup.

BUG= 661333 
TEST=content_shell should still work on Android and Mac.

Review-Url: https://codereview.chromium.org/2472563002
Cr-Commit-Position: refs/heads/master@{#429350}

[modify] https://crrev.com/b0ce0067c0be88ae92e126e06c9421894a3ae3ef/content/browser/BUILD.gn
[modify] https://crrev.com/b0ce0067c0be88ae92e126e06c9421894a3ae3ef/gpu/ipc/common/BUILD.gn

Comment 2 by jcivelli@chromium.org, Nov 2 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment