New issue
Advanced search Search tips

Issue 661301 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[MR UI] The MR ephemeral icon gets replaced by another icon from the overflow menu when hidden

Project Member Reported by taku...@chromium.org, Nov 1 2016

Issue description

Observed in M55+.

Steps to reproduce:
- Have a toolbar icon in the overflow (hotdog) menu
- Show the MR ephemeral icon by Casting
- Hide the ephemeral icon by stopping the Cast session
- The ephemeral icon gets replaced by the icon from the overflow, which should have stayed in the overflow menu.
 
Status: Assigned (was: Untriaged)
Components: -Blink>PresentationAPI Internals>Cast>UI
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f

commit 8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f
Author: takumif <takumif@chromium.org>
Date: Thu Nov 03 17:58:17 2016

Keep the toolbar overflow menu the same when removing a component action

Currently, when you remove a component action from the toolbar while there are actions in the overflow menu, one of the actions gets popped out of the menu to fill the component action's position. This CL makes such actions stay in the overflow menu.

BUG= 661301 

Review-Url: https://codereview.chromium.org/2469013003
Cr-Commit-Position: refs/heads/master@{#429645}

[modify] https://crrev.com/8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f/chrome/browser/ui/toolbar/toolbar_actions_model.cc
[modify] https://crrev.com/8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f/chrome/browser/ui/toolbar/toolbar_actions_model.h
[modify] https://crrev.com/8cf8f45a8ae3869aca0e9e7158ae00061cc6bc4f/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment