New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661297 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Nov 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-X

Blocked on:
issue 589943



Sign in to add a comment

Toggling bookmarks / downloads bar in non full screen does not update window.outerHeight property

Reported by peter....@gmail.com, Nov 1 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36

Steps to reproduce the problem:
1. Open dev console
2. Make sure window is not full screen height
3. console.log(window.outerHeight)
4. Toggle the bookmarks bar or trigger the download shelf
5. console.log(window.outerHeight)
6. Notice it has not been updated even though the window is taller/shorter.
7. Expand the window size horizontally (don't change the height)
8. console.log(window.outerHeight)
9. Notice the height is now correct after doing something which triggered a window.onresize

What is the expected behavior?
Toggling the bookmarks or downloads bar should update window.outerHeight property even when the window is not maximized.

What went wrong?
When Mac Chrome is not in full screen (or at least not full window height) and you toggle the bookmarks bar or downloads bar, the window size changes to make space for the download/bookmarks bar, but the window.outerHeight property stays out of sync until something else changes the size of the window again and then the window.outerHeight is up to date.

Note that in this case, we're also not getting a window.onresize event triggered. This only happens on Mac Chrome and when the window is not in full screen height.

Verified behavior on other browsers and it appears that when the window.onresize event is triggered, the window.outerHeight property is updated properly.

Triggers resize event (updates window.outerHeight property)

Mac - Firefox - Full screen     - Toggle Bookmarks = true
Mac - Firefox - Not full screen - Toggle Bookmarks = true
Mac - Safari  - Full screen     - Toggle Bookmarks = true
Mac - Safari  - Not full screen - Toggle Bookmarks = true
Mac - Chrome  = Full screen     - Toggle Bookmarks = true
[Mac - Chrome  = Not full screen - Toggle Bookmarks = FALSE]
Mac - Chrome  = Full screen     - Toggle Download bar = true
[Mac - Chrome  = Not full screen - Toggle Download bar = FALSE]

Win - Firefox - Full screen     - Toggle Bookmarks = true
Win - Firefox - Not Full screen - Toggle Bookmarks = true
Win - Edge    - Full screen     - Toggle Bookmarks = true
Win - Edge    - Not Full screen - Toggle Bookmarks = true
Win - Chrome  - Full screen     - Toggle Bookmarks = true
Win - Chrome  - Not Full screen - Toggle Bookmarks = true
Win - Chrome  - Full screen     - Toggle Download bar = true
Win - Chrome  - Not Full screen - Toggle Download bar = true

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 54.0.2840.71  Channel: stable
OS Version: OS X 10.12.0
Flash Version: Shockwave Flash 23.0 r0

Opened this after #660943 got set to wontFix but better explained the issue. Won't argue about the window.onresize event even though it behaves properly in every other browser and platform, but the window.outerHeight is not being updated and thats the core of the issue.
 
Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for the detailed writeup. Seems like a real platform integration issue, and should be relatively easy to fix. Over to shrike@ to find an OWNER.
Cc: shrike@chromium.org
Owner: sdy@chromium.org

Comment 3 by sdy@chromium.org, Feb 23 2017

Blockedon: 589943
Labels: M-X Hotlist-CocoaBrowser
This should be fixed in MacViews.
Status: Closed (was: Assigned)
This issue only affected the Cocoa UI, which is no longer supported and is being deleted in  issue 832676 .

Sign in to add a comment