New issue
Advanced search Search tips

Issue 661294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

PDF fields with same name incorrectly copy themselves over

Reported by mb...@publi-web.net, Nov 1 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36

Steps to reproduce the problem:
1. Download attached PDF 
2. Complete any field in the first page.
3. Scroll down to page 5, information was copied over in the corresponding field.
4. Scroll back to page 1, and fill another field.
5. Scroll back to page 5, the information only appears when the focus is on the field

What is the expected behavior?
Fields with the same name should always stay in sync as far as their content goes

What went wrong?
If a target field has been scrolled into view before, it will cause another bug that makes the field unsynced unless it has focus. 

Did this work before? Yes unsure, users reported it used to work

Chrome version: 54.0.2840.71  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0
 
ContratArrangementsPrealablesEN.pdf
917 KB Download
Labels: Pri-1
Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on windows 10, Ubuntu 14.04 and Mac 10.11.6 on latest chrome stable version 54.0.2840.87 
Issue is broken in M54. 

Bisect Info:
===========

Good build : 54.0.2830.0,  Revision Range(412124)
Bad build  : 54.0.2831.0,  Revision Range(412405)

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
============================================
https://chromium.googlesource.com/chromium/src/+log/8f4f4777ac1b971cb7ffe7e7443201edb4405bfc..487e8e3175b21038a5cc733494d263302ea61702

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/487e8e3175b21038a5cc733494d263302ea61702

From the above CL suspecting the below change
---------------------------
https://codereview.chromium.org/2246333002

thestig @- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.


Thank You...
Cc: tsepez@chromium.org
Owner: dsinclair@chromium.org
Based on the above, it's probably https://codereview.chromium.org/2251453002 and less likely https://codereview.chromium.org/2245863002
Status: Started (was: Assigned)
Reverting https://codereview.chromium.org/2251453002 does fix this issue, so that is the correct CL to blame.
Components: Internals>Plugins>PDF
Labels: OS-Chrome
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4093035dccdddf3a51f4035dfe9d3c90809ffb94

commit 4093035dccdddf3a51f4035dfe9d3c90809ffb94
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Sat Nov 05 00:33:18 2016

Roll src/third_party/pdfium/ ec64cee9a..04bebfe59 (4 commits).

https://pdfium.googlesource.com/pdfium.git/+log/ec64cee9accc..04bebfe590d6

$ git log ec64cee9a..04bebfe59 --date=short --no-merges --format='%ad %ae %s'
2016-11-04 thestig Implement FPDF_VIEWERREF_GetName() API.
2016-11-04 tsepez Pass object to ReplaceIndirectObjectIfHigherGeneration() by unique_ptr.
2016-11-04 tsepez CHECK for re-addition of indirect objects
2016-11-04 dsinclair Revert: Only create widgets if really needed

BUG= 632709 , 661294 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2480923002
Cr-Commit-Position: refs/heads/master@{#430089}

[modify] https://crrev.com/4093035dccdddf3a51f4035dfe9d3c90809ffb94/DEPS

Owner: ----
Status: Untriaged (was: Started)
Setting PDF bugs assigned to me back to untriaged so they can get re-assigned as needed.
Owner: dsinclair@chromium.org
Status: Fixed (was: Untriaged)
This was fixed.

Sign in to add a comment