LibFuzzer builds are broken due to pdfium change |
|||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/buildslaves/slave120-c1 Example: [979/9213] CXX obj/third_party/pdfium/testing/libfuzzer/pdf_xml_fuzzer/pdf_xml_fuzzer.o FAILED: obj/third_party/pdfium/testing/libfuzzer/pdf_xml_fuzzer/pdf_xml_fuzzer.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/pdfium/testing/libfuzzer/pdf_xml_fuzzer/pdf_xml_fuzzer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DADDRESS_SANITIZER -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DSANITIZER_COVERAGE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DV8_DEPRECATION_WARNINGS -D_FX_CPU_=_FX_X64_ -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -DPDFIUM_PRINT_TEXT_WITH_GDI -I../.. -Igen -I../../third_party/pdfium -I../../third_party/pdfium -I../../third_party/pdfium/third_party/freetype/include -I../../third_party/pdfium/third_party/freetype/include/freetype -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/build/slave/Libfuzzer_Upload_Linux_ASan/build/src=. -pthread -m64 -march=x86-64 -O1 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -gline-tables-only -gcolumn-info -fno-omit-frame-pointer -fsanitize-coverage=edge,indirect-calls,8bit-counters -mllvm -sanitizer-coverage-prune-blocks=1 -fsanitize=address -fsanitize-blacklist=../../tools/memory/asan/blacklist.txt -fsanitize=leak -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fPIC -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fno-exceptions -Wno-deprecated -c ../../third_party/pdfium/testing/libfuzzer/pdf_xml_fuzzer.cc -o obj/third_party/pdfium/testing/libfuzzer/pdf_xml_fuzzer/pdf_xml_fuzzer.o ../../third_party/pdfium/testing/libfuzzer/pdf_xml_fuzzer.cc:35:20: error: cannot initialize return object of type 'CFDE_XMLNode *' with an rvalue of type 'bool' return FALSE; ^~~~~ ../../third_party/pdfium/core/fxcrt/fx_system.h:73:15: note: expanded from macro 'FALSE' #define FALSE false ^~~~~ 1 error generated. Looks like this CL is a culprit: https://codereview.chromium.org/2468723002
,
Nov 1 2016
,
Nov 1 2016
FALSE is not a pointer. :).
,
Nov 1 2016
,
Nov 1 2016
https://pdfium.googlesource.com/pdfium/+/919e48d877e503f1ca250bc37324c9f7dc96d7a9
,
Nov 3 2016
Thanks Tom, builds are green! |
|||
►
Sign in to add a comment |
|||
Comment 1 by mmoroz@chromium.org
, Nov 1 2016