New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661260 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[USS] Improve MetadataChangeList usage for types using ModelTypeStore

Project Member Reported by s...@chromium.org, Nov 1 2016 
If the batch is known/created before the MCL is needed, it's trivial and easy to just have a pass through implementation, as long as the MCL doens't outlive the WriteBatch.

Comment 2 by maxbogue@chromium.org, Nov 3 2016

Owner: maxbogue@chromium.org
Summary: [USS] Improve MetadataChangeList usage for types using ModelTypeStore (was: [USS] Make a new MetadataChangeList implementation that passes through to a WriteBatch)
Updating this bug to encompass our newly agreed upon changes. We now want to have two different ways of getting MCLs from WriteBatch, depending on whether the user has a WriteBatch object already in scope or not.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b065e269ab993b5ffcb2d88344b8754894b05c

commit 73b065e269ab993b5ffcb2d88344b8754894b05c
Author: maxbogue <maxbogue@chromium.org>
Date: Fri Nov 04 01:08:00 2016

[Sync] Improve MetadataChangeList usage for types using ModelTypeStore.

- Added WriteBatch::CreateMetadataChangeList() and
  WriteBatch::GetMetadataChangeList().
- Split off InMemoryMetadataChangeList from SimpleMCL to be a new base
  class for MCLs that store things in memory.
- Split off AccumulatingMetadataChangeList from SimpleMCL.
- Move SimpleMCL inside FakeModelTypeSyncBridge as
  TestMetadataChangeList.

BUG= 661260 

Review-Url: https://codereview.chromium.org/2473553003
Cr-Commit-Position: refs/heads/master@{#429749}

[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/BUILD.gn
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/device_info/device_info_sync_bridge.cc
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/device_info/device_info_sync_bridge.h
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model/fake_model_type_sync_bridge.cc
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model/mock_model_type_store.cc
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model/model_type_store.cc
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model/model_type_store.h
[delete] https://crrev.com/cdb23a159c0f4cbd8e18f9b15c878cc20a4ba48d/components/sync/model/simple_metadata_change_list.cc
[delete] https://crrev.com/cdb23a159c0f4cbd8e18f9b15c878cc20a4ba48d/components/sync/model/simple_metadata_change_list.h
[add] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/accumulating_metadata_change_list.cc
[add] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/accumulating_metadata_change_list.h
[rename] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/accumulating_metadata_change_list_unittest.cc
[add] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/in_memory_metadata_change_list.cc
[add] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/in_memory_metadata_change_list.h
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/model_type_store_impl.cc
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/model_type_store_impl.h
[modify] https://crrev.com/73b065e269ab993b5ffcb2d88344b8754894b05c/components/sync/model_impl/shared_model_type_processor_unittest.cc

Comment 4 by maxbogue@chromium.org, Nov 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment