New issue
Advanced search Search tips

Issue 661259 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

RTL Scrollbar on left grows in the wrong direction

Project Member Reported by bokan@chromium.org, Nov 1 2016

Issue description

What steps will reproduce the problem?
(1) Navigate to this URL:
data:text/html;charset=utf8,<div dir="rtl" style="height: 100px; width: 300px; background: aliceblue; overflow: scroll"><div style="height: 600px;">

What is the expected output?
The scrollbar should be attached at the extreme left edge of the div and grow to the right when the mouse moves near it.

What do you see instead?
The scrollbar is attached such that at its full width, it's attached to the left. When the mouse moves near it, it grows to the left.

We should change the transform origin for RTL scrollbars to be the left side of the scrollbar such that it expands to the right.


Please use labels and text to provide additional information.

 

Comment 1 by bokan@chromium.org, Nov 1 2016

Sahel, this seems more urgent than the main frame scrollbar issue. Please prioritize this issue for now.

Comment 2 by sahel@chromium.org, Nov 1 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b504ebcca5ba3e17640034a59f17af670a530d7d

commit b504ebcca5ba3e17640034a59f17af670a530d7d
Author: sahel <sahel@chromium.org>
Date: Fri Nov 04 21:22:25 2016

Left side vertical MD scrollbars grow toward right.

This patch plumbs through the is_overlay and is_left_side_vertical_scrollbar flags for painted scrollbar layers.

BUG= 661259 
TEST=ScrollbarLayerTest.ThumbRectForOverlayLeftSideVerticalScrollbar
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2468423004
Cr-Commit-Position: refs/heads/master@{#430019}

[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/layers/painted_scrollbar_layer.cc
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/layers/painted_scrollbar_layer_impl.cc
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/layers/painted_scrollbar_layer_impl.h
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/layers/painted_scrollbar_layer_impl_unittest.cc
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/layers/scrollbar_layer_unittest.cc
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/test/fake_painted_scrollbar_layer.cc
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/test/fake_painted_scrollbar_layer.h
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/test/fake_scrollbar.cc
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/test/fake_scrollbar.h
[modify] https://crrev.com/b504ebcca5ba3e17640034a59f17af670a530d7d/cc/test/layer_test_common.h

Comment 4 by sahel@chromium.org, Nov 7 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 9011.0.0, 57.0.2926.0

Sign in to add a comment