servod needs a way to un-override controls or refactor xmls to remove servo_v2 specific configs. |
||
Issue descriptionCurrently board overlays have various controls overridden, containing servo_v2/3 specific configs in the board overlay. servod either needs a way to override these overrides to allow for servo_micro configs, or the xml needs a refactor to remove servo v2 hardware description from dut configs. Examples: servoflex_v2_r0_p50.xml (included in board configs): spi1_buf_on_flex_en servo_glados_overlay.xml: ec3po_usbpd_uart_pty
,
Nov 2 2016
Since overrides original intent was to make changes like assertion or push-pull but maintain the functionality defined in the Servo V2 debug header specification I'd prefer the latter, xml refactor, as a long-term strategy. So how about removing the V2/V3 specific controls from the overlay and instead add them to an xml file either a) aptly named that can be found by knowing servo version and board (glados_v2_hacks.xml) and then implicitly including it like we currently do servo_<board>_overlay.xml b) adding a subfield to XML's include field that can be checked prior to sourcing the additional xml file. a) probably easier b) would allow more flexibility including when they get included.
,
Aug 3
Feel free to reopen if still relevant. |
||
►
Sign in to add a comment |
||
Comment 1 by nsanders@chromium.org
, Nov 1 2016