New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661254 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Run ocmock support unittests upstream

Project Member Reported by baxley@chromium.org, Nov 1 2016

Issue description

These unit tests are run downstream, but all of the code is upstream. Tests should also be run upstream. ocmock_complex_type_helper_unittest.mm is the test file.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 2 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -baxley@chromium.org
Owner: baxley@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7880db4c845c9f3be82835c117b50291a83ad6ff

commit 7880db4c845c9f3be82835c117b50291a83ad6ff
Author: Mike Baxley <baxley@chromium.org>
Date: Wed Feb 14 01:18:13 2018

Add ocmock_support_unittests to iOS unit test suite.

Tests have been running downstream, but everything that is built and
run is available upstream.

Bug:  661254 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I234ce0108535f58d217f362c72ce927c481ad845
Reviewed-on: https://chromium-review.googlesource.com/884305
Commit-Queue: Mike Baxley <baxley@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536586}
[modify] https://crrev.com/7880db4c845c9f3be82835c117b50291a83ad6ff/ios/build/bots/tests/common_tests.json
[modify] https://crrev.com/7880db4c845c9f3be82835c117b50291a83ad6ff/ios/testing/BUILD.gn
[modify] https://crrev.com/7880db4c845c9f3be82835c117b50291a83ad6ff/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/7880db4c845c9f3be82835c117b50291a83ad6ff/testing/buildbot/manage.py

Comment 4 by baxley@chromium.org, Feb 14 2018

Status: Fixed (was: Assigned)

Sign in to add a comment