Stylize the add billing address option in the payment request card editor. |
|||||
Issue descriptionIt should show "+ ADD ADDRESS" in blue.
,
Nov 1 2016
I like it. Hwi?
,
Nov 1 2016
c3: correct - reposting with correct links Thanks for working on this, sebsg@ It'll be great to use the specification in the redlines: go/list-dropdown Also, the plus icon is used in the fullsheet UI (go/03-address-checking-png-folio) so we can reuse the asset.
,
Nov 1 2016
Thanks, Do you mind if I only address the + icon in this CL? I'd make the changes to all dropdowns in another one.
,
Nov 1 2016
sebsg@ 1. If possible, Icon + Font weight in medium (or bold for Pre-L) please. The same already exists in other UI e.g. crbug.com/661287 2. It'll be nice we have a separate crbug for the polish. Thanks a lot!
,
Nov 1 2016
Take 2 :) And created the bug at crbug.com/661357 Thanks!
,
Nov 2 2016
lgtm - Thanks, sebsg@! 😊
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ff2921f019f376f6099436d0b4f8f3ddcac5a45 commit 6ff2921f019f376f6099436d0b4f8f3ddcac5a45 Author: sebsg <sebsg@chromium.org> Date: Tue Nov 08 22:50:15 2016 [Payments] Style the add address option in billing address selection. BUG= 661249 Review-Url: https://codereview.chromium.org/2479613002 Cr-Commit-Position: refs/heads/master@{#430740} [add] https://crrev.com/6ff2921f019f376f6099436d0b4f8f3ddcac5a45/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/BillingAddressAdapter.java [modify] https://crrev.com/6ff2921f019f376f6099436d0b4f8f3ddcac5a45/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java [delete] https://crrev.com/23665d9436ba067872f0b2c652dce17404393657/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/HintArrayAdapter.java [modify] https://crrev.com/6ff2921f019f376f6099436d0b4f8f3ddcac5a45/chrome/android/java_sources.gni
,
Nov 9 2016
,
Nov 9 2016
,
Nov 16 2016
Verified in 56.0.2919.3 build
,
Jun 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by se...@chromium.org
, Nov 1 2016399 KB
399 KB View Download