Issue 661236 link

Starred by 1 user

Issue metadata

Status:	Assigned
Owner:	chaopeng@chromium.org
Cc:	skobes@chromium.org bokan@chromium.org
Components:	Blink>Scroll
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Task
Hotlist-Input-Dev

Blocked on:
issue 550971

Blocking:
issue 456861
issue 531603

Refactor scrollbar creation and managing code in Blink Main Thread (master bug)

Project Member Reported by ymalik@chromium.org, Nov 1 2016

Issue description

There is a bunch of common scrollbar code between FrameView and PaintLayerScrollableArea. 

I don't think there's a real reason why these classes have different logic.

There's also differences between platforms, e.g, on Android, the visual viewport supplies scrollbars and Windows, FV supplies scrollbars. 

There's room for a lot of cleanup here and all the scrollbar code should go into a common place.

Comment 1 by bokan@chromium.org, Nov 1 2016

As Steve mentioned, I don't think we should waste time factoring code out of FrameView since root-layer-scrolling will remove it all anyway. I'd like to see us factor out the scrollbar code from PaintLayerScrollableArea, VisualViewport and RootFrameViewport and remove platform differences. In particular the difference between main frame scrollbars on Android and other platforms is painful.

Comment 2 by ymalik@chromium.org, Nov 9 2016

Here is bokan's rough proposal for the what the scrollbar code should look like in blink: https://drive.google.com/file/d/0B600QF7NoJmvdkMtbTN0V2JiRVU/view

Comment 3 Deleted

Comment 4 by bokan@chromium.org, Nov 10 2016

Sorry, here's a public link: https://drive.google.com/file/d/0B8erhfwi4twRYlg4akVtU1lwRUE/view?usp=sharing

Comment 5 by ymalik@chromium.org, Nov 16 2016

Blockedon: 550971

Comment 6 by ymalik@chromium.org, Nov 16 2016

Labels: -Pri-3 Pri-2
Summary: Refactor scrollbar creation and managing code in Blink Main Thread (master bug) (was: Refactor scrollbar creation and managing code in Blink Main Thread )