New issue
Advanced search Search tips

Issue 661215 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Disallow [ Missing ] expectations in test expectations files.

Project Member Reported by qyears...@chromium.org, Nov 1 2016 
Currently, one can add [ Missing ] expectations to TestExpectations, which will make tests pass when baselines are missing.

Support for this type of expectation is probably not necessary, since in most cases one could use NeedsRebaseline or NeedsManualRebaseline, or, if possible, fetch and commit new baselines.

Some context: https://codereview.chromium.org/2453223002/

Some related issues:
 - We should also disallow WontFix expectations in TestExpectations, since WontFix lines should only go in NeverFixTests.
 - We could likely simplify the expectations NeedsRebaseline, NeedsManualRebaseline, and Rebaseline by removing at least one of them.

Also related to bug 652357.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0b38137804a4f799ec31f34ee3cc1b59b553ae5

commit b0b38137804a4f799ec31f34ee3cc1b59b553ae5
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Nov 02 17:40:03 2016

Disallow [ Missing ] expectations in test expectations files.

Reason: In general, cases where people would need to add Missing expectations should probably be handled generating/fetching new baselines, or adding NeedsRebaseline or NeedsManualRebaseline expectations.

This CL also removes "failures/expected/missing_*" tests that are added in layout_tests/port/test.py.

BUG= 661215 ,591500

Review-Url: https://codereview.chromium.org/2467013002
Cr-Commit-Position: refs/heads/master@{#429326}

[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py
[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/b0b38137804a4f799ec31f34ee3cc1b59b553ae5/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py

Comment 2 by qyears...@chromium.org, Dec 17 2016

Owner: qyears...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment