New issue
Advanced search Search tips

Issue 661207 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 57-Dev
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----



Sign in to add a comment

Implement AudioScheduledSourceNode

Project Member Reported by rtoy@chromium.org, Nov 1 2016

Issue description

See https://github.com/WebAudio/web-audio-api/issues/960 for the issue and https://github.com/WebAudio/web-audio-api/pull/1017 for the resolution.

Curiously, we already have an AudioScheduledSource class; just need to make it officially exposed.

 

Comment 1 by rtoy@chromium.org, Nov 16 2016

Labels: -Type-Bug Type-Launch-OWP
Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00971f38908388728f49cd5127b9c6c6761d035f

commit 00971f38908388728f49cd5127b9c6c6761d035f
Author: rtoy <rtoy@chromium.org>
Date: Wed Jan 04 01:20:36 2017

Implement AudioScheduledSourceNode

Add AudioScheduledSourceNode as a base class of schedulable source nodes to capture
the common features of these source nodes.

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Vr6XJNfVAK4/RU3AP19WAQAJ

BUG= 661207 
TEST=audio-scheduled-source-basic.html

Review-Url: https://codereview.chromium.org/2471353004
Cr-Commit-Position: refs/heads/master@{#441277}

[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
[add] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h
[add] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.idl
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.idl
[modify] https://crrev.com/00971f38908388728f49cd5127b9c6c6761d035f/third_party/WebKit/Source/modules/webaudio/OscillatorNode.idl

Comment 3 by rtoy@chromium.org, Jan 5 2017

Status: Verified (was: Started)

Comment 4 by rtoy@chromium.org, Jan 12 2017

Labels: Launch-M-Target-57-Dev

Sign in to add a comment