New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661206 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug


Participants' hotlists:
HSTS-Preload


Sign in to add a comment

Remove |domain_id| from PreloadResult

Project Member Reported by est...@chromium.org, Nov 1 2016

Issue description

As of https://codereview.chromium.org/2467953002, PreloadResult's domain_id field is not used, so we should just remove it from the preload list format.
 
Cc: lgar...@chromium.org
Labels: Hotlist-HSTS-Preload
Cc: mart...@martijnc.be
martijn@: FYI, we'll want to get rid of this at some point. Feel free to yank it out if it makes your CLs easier.

Comment 4 by mart...@martijnc.be, Jan 19 2017

I was planning to fix  issue 595493  first. Once that's done, removing this will be a lot easier.

Doing this now means more rebasing (for me) and probably results in a large patch that needs to be landed manually (which I can't do).

I hope to have the tests for the generator ready next week so that we can start running the generator automatically and can start making progress on this (and other open issues). But it looks like we're going to miss M57 :(.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26fed56d4ceba0ba676aafe34083d71ef261afb

commit b26fed56d4ceba0ba676aafe34083d71ef261afb
Author: Martijn Croonen <martijn@martijnc.be>
Date: Thu Apr 20 18:43:52 2017

Remove domain_ids from the transport security state preload format.

The domain IDs are no longer used. Usage was removed last year in
https://codereview.chromium.org/2467953002.

BUG= 661206 

patch from issue 2811493002 at patchset 20001 (http://crrev.com/2811493002#ps20001)

Change-Id: I35e2a299163487d155333922ff800a882aa32bbc
Reviewed-on: https://chromium-review.googlesource.com/482259
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#466081}
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state.cc
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state.h
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state_static.h
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state_static.json
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state_static_unittest.template
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state_static_unittest1.json
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state_static_unittest2.json
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/http/transport_security_state_static_unittest3.json
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/input_file_parsers.cc
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/input_file_parsers.h
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/input_file_parsers_unittest.cc
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/preloaded_state_generator.cc
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/preloaded_state_generator.h
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/resources/transport_security_state_static.template
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/transport_security_state_entry.h
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/transport_security_state_generator.cc
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/trie/trie_writer.cc
[modify] https://crrev.com/b26fed56d4ceba0ba676aafe34083d71ef261afb/net/tools/transport_security_state_generator/trie/trie_writer.h

Comment 6 by peter@chromium.org, May 1 2017

Status: Fixed (was: Available)

Sign in to add a comment