New issue
Advanced search Search tips

Issue 661199 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Implement word wrapping and panning in multiline braille

Project Member Reported by ultimatedbz@google.com, Nov 1 2016

Issue description

The multiline braille code currently does not support word wrapping and panning.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a59dc298b6f036467777ae3658fe8546f0a5978

commit 2a59dc298b6f036467777ae3658fe8546f0a5978
Author: ultimatedbz <ultimatedbz@google.com>
Date: Thu Dec 08 20:19:31 2016

Implement word wrapping and panning in multiline Braille.

The current code doesn't support word wrapping when displaying multiline braille.
The panStrategy class also doesn't allow panning in multiline. This CL changes
the panStrategy completely. Before, it only returns starting and ending indices
of the current viewport. Now, it stores the fixed and wrapped versions of the
braille that is displayed. It also keeps the state of whether the pan strategy
is currently "fixed" or "wrapped". The panStrategy class also now supports
panning in multiline. Changes to the braille display manager have been made to
utilize the new panStrategy. In addition, changes have been made to the braille
captions background so that grouping works, even if the viewport is not at the
beginning of the buffer. Specifically, it uses two offsets that the panStrategy
class generates to find the correct indices for braille and text.

BUG=661199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2496823002
Cr-Commit-Position: refs/heads/master@{#437318}

[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager_test.unitjs
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/braille/pan_strategy.js
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/braille/pan_strategy_test.unitjs
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.css
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
[modify] https://crrev.com/2a59dc298b6f036467777ae3658fe8546f0a5978/chrome/browser/resources/chromeos/chromevox/testing/assert_additions.js

Components: UI>Accessibility>ChromeVox
Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.

Sign in to add a comment