New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661188 link

Starred by 2 users
Status: Fixed
Owner:
█ aber...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ miguelg@chromium.org
ew...@chromium.org
█ bauerb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Use key/value backup for Android backup and restore

Project Member Reported by aber...@chromium.org, Nov 1 2016 
In Chrome M52 we implemented backup and restore in Chrome for Android using Android Auto backup (due to bugs, backup was only actually enabled in M55). Following a review of this we have decided to switch to key/value backup, largely because this will allow users to restore backups from older (pre-Android M) phones.

For more details see https://docs.google.com/a/google.com/document/d/1ZMfb-b_2caoinQMSfEgsbc9gE9CoaeRK4ndWn-SdQIQ/edit?usp=sharing (Google internal only).
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cd30398e5107e2163ec51595f18fe9290c50e00

commit 9cd30398e5107e2163ec51595f18fe9290c50e00
Author: aberent <aberent@chromium.org>
Date: Tue Nov 01 17:51:07 2016

Disable Android backup and restore

This is in preparation for re-implementing it using key/value backup.
We however want to disable Auto-backup (and all backups) in M55, since
the Auto-backups will never be used, and we are unsure whether restoring
key/value backups will work correctly in the presence of older
Auto-backups.

BUG= 661188 

Review-Url: https://codereview.chromium.org/2470823002
Cr-Commit-Position: refs/heads/master@{#429043}

[modify] https://crrev.com/9cd30398e5107e2163ec51595f18fe9290c50e00/chrome/android/java/AndroidManifest.xml

Comment 2 by aber...@chromium.org, Nov 1 2016

Labels: Merge-Request-55

Comment 3 by dimu@chromium.org, Nov 1 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a0cb7a2166ee5400a8979b97ebe58080a98ee7e

commit 2a0cb7a2166ee5400a8979b97ebe58080a98ee7e
Author: Anthony Berent <aberent@chromium.org>
Date: Wed Nov 02 09:09:57 2016

Disable Android backup and restore

This is in preparation for re-implementing it using key/value backup.
We however want to disable Auto-backup (and all backups) in M55, since
the Auto-backups will never be used, and we are unsure whether restoring
key/value backups will work correctly in the presence of older
Auto-backups.

BUG= 661188 

Review-Url: https://codereview.chromium.org/2470823002
Cr-Commit-Position: refs/heads/master@{#429043}
(cherry picked from commit 9cd30398e5107e2163ec51595f18fe9290c50e00)

Review URL: https://codereview.chromium.org/2473683002 .

Cr-Commit-Position: refs/branch-heads/2883@{#420}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/2a0cb7a2166ee5400a8979b97ebe58080a98ee7e/chrome/android/java/AndroidManifest.xml

Comment 5 by aber...@chromium.org, Nov 2 2016

Labels: -Hotlist-Merge-Approved -merge-merged-2883
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/595b491b9d7914d84e36b62a8215a5acc91fca68

commit 595b491b9d7914d84e36b62a8215a5acc91fca68
Author: Anthony Berent <aberent@chromium.org>
Date: Thu Nov 10 21:51:30 2016

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d56b7ec3e6e6c3236835414584f4205283beb218

commit d56b7ec3e6e6c3236835414584f4205283beb218
Author: aberent <aberent@chromium.org>
Date: Wed Nov 16 16:43:27 2016

Implement Android key/value backup

This replaces our previous impmentation of (Dolly) Auto Backup.
Only the preferences needed to restore the user's signin atate
and sync state are backed up.

BUG= 661188 

Review-Url: https://codereview.chromium.org/2496693002
Cr-Commit-Position: refs/heads/master@{#432517}

[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[add] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/android/java_sources.gni
[delete] https://crrev.com/bafa9a4a5a355f516d15f09d67fea74c91c3c42b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/BUILD.gn
[add] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/android/chrome_backup_agent.cc
[add] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/android/chrome_backup_agent.h
[add] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/android/chrome_backup_agent_unittest.cc
[add] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/android/chrome_backup_watcher.cc
[add] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/android/chrome_backup_watcher.h
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/browser/chrome_browser_main_android.h
[modify] https://crrev.com/d56b7ec3e6e6c3236835414584f4205283beb218/chrome/test/BUILD.gn

Comment 9 by aber...@chromium.org, Nov 16 2016 

Not closing yet, although all the patches have landed, since we are still discussing whether to merge to M55.

Comment 10 by aber...@chromium.org, Nov 17 2016

Labels: Merge-Request-55

Comment 11 by dimu@chromium.org, Nov 17 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 17 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/75d1ca98de4e460c26e8b9edfd3cc486c4b852b9

commit 75d1ca98de4e460c26e8b9edfd3cc486c4b852b9
Author: Anthony Berent <aberent@chromium.org>
Date: Thu Nov 10 21:51:30 2016
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9dd9283bac8aa9908d6868a052e088a9839499b4

commit 9dd9283bac8aa9908d6868a052e088a9839499b4
Author: Anthony Berent <aberent@chromium.org>
Date: Thu Nov 17 11:34:36 2016

Implement Android key/value backup

This replaces our previous impmentation of (Dolly) Auto Backup.
Only the preferences needed to restore the user's signin atate
and sync state are backed up.

BUG= 661188 

Review-Url: https://codereview.chromium.org/2496693002
Cr-Commit-Position: refs/heads/master@{#432517}
(cherry picked from commit d56b7ec3e6e6c3236835414584f4205283beb218)

Review URL: https://codereview.chromium.org/2511713002 .

Cr-Commit-Position: refs/branch-heads/2883@{#599}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[add] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/android/java_sources.gni
[delete] https://crrev.com/9bbebf3ba3a5b8ff0a645d026a0ede213135521d/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/BUILD.gn
[add] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/android/chrome_backup_agent.cc
[add] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/android/chrome_backup_agent.h
[add] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/android/chrome_backup_agent_unittest.cc
[add] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/android/chrome_backup_watcher.cc
[add] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/android/chrome_backup_watcher.h
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/browser/chrome_browser_main_android.h
[modify] https://crrev.com/9dd9283bac8aa9908d6868a052e088a9839499b4/chrome/test/BUILD.gn

Comment 14 by aber...@chromium.org, Nov 17 2016

Labels: -M-56 -Hotlist-Merge-Approved M-55
Status: Fixed (was: Started)
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be3273ff834b80380faebfd18b002509586c7dc

commit 6be3273ff834b80380faebfd18b002509586c7dc
Author: amineer <amineer@google.com>
Date: Fri Nov 18 04:01:33 2016

Revert of Implement Android key/value backup (patchset #1 id:1 of https://codereview.chromium.org/2511713002/ )

Reason for revert:
Breaks build.  Please don't reland.

https://uberchromegw.corp.google.com/i/official.android.continuous/builders/beta-arm/builds/5096

Original issue's description:
> Implement Android key/value backup
>
> This replaces our previous impmentation of (Dolly) Auto Backup.
> Only the preferences needed to restore the user's signin atate
> and sync state are backed up.
>
> BUG= 661188 
>
> Review-Url: https://codereview.chromium.org/2496693002
> Cr-Commit-Position: refs/heads/master@{#432517}
> (cherry picked from commit d56b7ec3e6e6c3236835414584f4205283beb218)
>
> Committed: https://chromium.googlesource.com/chromium/src/+/9dd9283bac8aa9908d6868a052e088a9839499b4

TBR=aberent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 661188 

Review-Url: https://codereview.chromium.org/2509323004
Cr-Commit-Position: refs/branch-heads/2883@{#605}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[delete] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/android/java_sources.gni
[add] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/browser/BUILD.gn
[delete] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/chrome/browser/android/chrome_backup_agent.cc
[delete] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/chrome/browser/android/chrome_backup_agent.h
[delete] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/chrome/browser/android/chrome_backup_agent_unittest.cc
[delete] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/chrome/browser/android/chrome_backup_watcher.cc
[delete] https://crrev.com/b4fdf5cba5c295b1702bad390bd999b9f0be0503/chrome/browser/android/chrome_backup_watcher.h
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/browser/android/chrome_jni_registrar.cc
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/browser/chrome_browser_main_android.h
[modify] https://crrev.com/6be3273ff834b80380faebfd18b002509586c7dc/chrome/test/BUILD.gn

Comment 16 by aber...@chromium.org, Nov 21 2016

Labels: -M-55 -merge-merged-2883 M-56
The build was broken because one of the header files this uses had moved between revisions. Having said this, we are now not going to merge this to M55, so closing.
►

Sign in to add a comment