“git cl land” should show the hash of what landed |
|||||||||
Issue descriptionLet me show you a git cl land: -- $ git cl land Using 50% similarity for rename/copy detection. Override with --similarity. r you. Are you sure you wish to bypass it?e, which can test and land changes fo ort.s Enter to continue, Ctrl+C to ab WARNING: some changes from local branch haven't been uploaded Do you want to submit latest Gerrit patchset and bypass hooks?yes WARNING: bypassing hooks and submitting latest uploaded patchset Issue https://chromium-review.googlesource.com/405468 has been submitted. -- It would be nice if it told me that fd751f4708cc6f7d95ff21f9f300403b7158573b is what landed, and maybe to provide a link to https://chromium.googlesource.com/crashpad/crashpad/+/fd751f4708cc6f7d95ff21f9f300403b7158573b.
,
Nov 1 2016
,
Nov 1 2016
,
Nov 1 2016
,
Nov 1 2016
Unfortunately, when using the Gerrit API to submit the change, the response that we get back does not include the final hash of the submitted commit: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#submit-change I *think* this can be done with the "get revisions" call, using the string literal "current" to get the most recent commit in the change: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-commit
,
Nov 1 2016
This might work (completely untested so far): https://codereview.chromium.org/2466953003
,
Nov 1 2016
I filed bug gerrit:4846 about surfacing the hash somewhere else too. It’s possible (even likely?) that the Gerrit API _should_ include the hash, so if that helps fix both bugs, maybe it’s the most correct way to proceed.
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/32978d969ce27fa9568b30f0cdb556036a645d1e commit 32978d969ce27fa9568b30f0cdb556036a645d1e Author: agable <agable@chromium.org> Date: Tue Nov 01 19:55:02 2016 git-cl-land: print url of final commit location BUG= 661187 Review-Url: https://codereview.chromium.org/2466953003 [modify] https://crrev.com/32978d969ce27fa9568b30f0cdb556036a645d1e/gerrit_util.py [modify] https://crrev.com/32978d969ce27fa9568b30f0cdb556036a645d1e/git_cl.py [modify] https://crrev.com/32978d969ce27fa9568b30f0cdb556036a645d1e/tests/git_cl_test.py
,
Nov 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/32978d969ce27fa9568b30f0cdb556036a645d1e commit 32978d969ce27fa9568b30f0cdb556036a645d1e Author: agable <agable@chromium.org> Date: Tue Nov 01 19:55:02 2016 git-cl-land: print url of final commit location BUG= 661187 Review-Url: https://codereview.chromium.org/2466953003 [modify] https://crrev.com/32978d969ce27fa9568b30f0cdb556036a645d1e/gerrit_util.py [modify] https://crrev.com/32978d969ce27fa9568b30f0cdb556036a645d1e/git_cl.py [modify] https://crrev.com/32978d969ce27fa9568b30f0cdb556036a645d1e/tests/git_cl_test.py
,
Nov 1 2016
,
Nov 3 2016
I don’t think that this is working. I made sure that depot_tools were synced to include this before landing something. depot_tools is at e0b205e884ca, 2016-11-03 00:13, and the fix for this landed at 32978d969ce2, 2016-11-01 19:55. I was landing https://chromium-review.googlesource.com/407087/, which made it into Crashpad at https://chromium.googlesource.com/crashpad/crashpad/+/375082098deb5efd7c10f108c99fbc74860c6f72. -- $ git cl land Using 50% similarity for rename/copy detection. Override with --similarity. r you. Are you sure you wish to bypass it?e, which can test and land changes fo ort.s Enter to continue, Ctrl+C to ab Running presubmit commit checks ... Presubmit checks passed. Issue https://chromium-review.googlesource.com/407087 has been submitted. $ --
,
Nov 22 2016
,
Dec 14 2016
I can verify that it doesn't work. I made a dumb mistake, here's the fix: https://chromium-review.googlesource.com/c/419782/
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/02cdbb45a71bb5f5d64512f57c5e012b44b44dd9 commit 02cdbb45a71bb5f5d64512f57c5e012b44b44dd9 Author: Aaron Gable <agable@chromium.org> Date: Wed Dec 14 00:24:25 2016 Fix gerrit/gitiles typo in git_cl This is a fix to 32978d969ce27fa9568b30f0cdb556036a645d1e, which introduced a "Landed as <gerrit link>" feature to git-cl, but which at the last minute introduced a typo causing the whole feature to not actually work. BUG= 661187 Change-Id: Ifef3379a51f035973bc5f3842862528f90bfdf84 Reviewed-on: https://chromium-review.googlesource.com/419782 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/02cdbb45a71bb5f5d64512f57c5e012b44b44dd9/git_cl.py [modify] https://crrev.com/02cdbb45a71bb5f5d64512f57c5e012b44b44dd9/tests/git_cl_test.py
,
Dec 14 2016
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mark@chromium.org
, Nov 1 2016