Chromium archived build needs to include icudtl.dat |
||||
Issue descriptionThe archived builds used by the bisect script don't include icudtl.dat, forcing the developer to grab their own copy - this causes problems if they pick the wrong version Anyone know who owns the script that packages the archived builds used for bisecting? I think this is mainly an issue for Chromium builds of Linux and Chrome OS. The official Chrome builds aren't a problem since they package everything. @glevin and I can provide more details if this is unclear, I just don't know who owns the packaging scripts or even where they live
,
Jan 27 2018
mmoss is this your team? Where are you getting the archived builds? What bisect script are you using?
,
Jan 27 2018
I'm not sure which builds are used for that, but I think most things that get archived, from wherever, are still defined by the FILES.cfg files: https://chromium.googlesource.com/chromium/src.git/+/master/chrome/tools/build/win/FILES.cfg +prasadv, who knows about bisect stuff, and can probably verify which archives we're talking about.
,
Jan 27 2018
Hrm, and it looks like icudtl.dat is defined in there: https://chromium.googlesource.com/chromium/src.git/+/master/chrome/tools/build/win/FILES.cfg#101 so if it's not in the bisect archives, then I have no idea how those are being generated.
,
Jan 27 2018
Note that blocked Issue 600740 contains more info about how this affects bisects in practice.
,
Jan 28 2018
Bisect uses lightweight builds of the binaries produced by chromeperf builders(https://uberchromegw.corp.google.com/i/chromium.perf/console). These builds are stored at https://pantheon.corp.google.com/storage/browser/chrome-test-builds/official-by-commit. Looks like icudtl.dat file is also included in the archive used for bisects. https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FLinux_Builder%2F176694%2F%2B%2Frecipes%2Fsteps%2Fpackage_build_for_bisect%2F0%2Fstdout. +dtu@ from chromeperf team |
||||
►
Sign in to add a comment |
||||
Comment 1 by phajdan.jr@chromium.org
, Nov 2 2016