New issue
Advanced search Search tips

Issue 661161 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.6% regression in angle_perftests at 428795:428860

Project Member Reported by jmad...@chromium.org, Nov 1 2016

Issue description

A 6.6% regression.
Master:	ChromiumPerf
Bot:	chromium-rel-win7-gpu-nvidia
Test:	angle_perftests/DrawCallPerf_d3d11_null/score
Revision Range:	428795 - 428860
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=661161

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgw-6qvgsM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-nvidia
Owner: jmad...@chromium.org

=== Auto-CCing suspected CL author jmadill@chromium.org ===

Hi jmadill@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Make ASSERT reference the conditional expression.
Author  : Jamie Madill
Commit description:
  
This should prevent further unexpected bot breakage due to
unreferenced variables in the ASSERT expression.

Also remove the no longer needed variable referencing macro.

BUG= angleproject:1586 

Change-Id: I127695165bdfe39c51fe8d17e00daf6bf2fa8252
Reviewed-on: https://chromium-review.googlesource.com/404948
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit  : 60e6edfa7fe2549c8e60fec84d3af225e185a85d
Date    : Mon Oct 31 20:25:24 2016


===== TESTED REVISIONS =====
Revision                          Mean     Std Dev  N  Good?
chromium@428794                   27642.2  132.995  5  good
chromium@428827                   28127.2  86.7047  5  good
chromium@428836                   28065.2  37.1308  5  good
chromium@428838                   27991.8  152.664  5  good
chromium@428838,angle@1df1602232  28368.8  86.2943  5  good
chromium@428838,angle@d89792f42b  27946.0  238.914  5  good
chromium@428838,angle@60e6edfa7f  26375.6  27.4099  5  bad    <--
chromium@428839                   26431.6  63.6498  5  bad
chromium@428840                   26376.6  84.8605  5  bad
chromium@428844                   26387.8  120.552  5  bad
chromium@428860                   26311.4  113.088  5  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 661161

Test Command: .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1
Test Metric: DrawCallPerf_d3d11_null/score
Relative Change: 4.81%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1944
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997187983852882864


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5818146718482432

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

=== Auto-CCing suspected CL author jmadill@chromium.org ===

Hi jmadill@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Buffer11: Keep system memory storage for large UBOs.
Author  : Jamie Madill
Commit description:
  
The system memory storage is needed to back UBOs larger than the max
constant buffer size in D3D11 Windows 7. Because readback from UBOs
can be tricky, the system memory storage keeps the canonical copy of
the data in this case.

We can also extend this to add a workaround to fix the outstanding
failure cases of UBOs on Intel.

BUG= chromium:660670 

Change-Id: Ia3119d3064d10c4262def4c5a967972b4de2d10f
Reviewed-on: https://chromium-review.googlesource.com/405367
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit  : d89792f42b28c3d7ed822a4f3319ce2ebe73a11b
Date    : Mon Oct 31 19:48:59 2016


===== TESTED REVISIONS =====
Revision                          Mean     Std Dev  N  Good?
chromium@428794                   27610.8  209.303  5  good
chromium@428827                   28054.0  178.82   5  good
chromium@428836                   28086.0  65.8407  5  good
chromium@428838                   28139.0  64.9962  5  good
chromium@428838,angle@1df1602232  28296.8  132.686  5  good
chromium@428838,angle@d89792f42b  26987.2  1377.84  5  bad    <--
chromium@428838,angle@60e6edfa7f  26174.2  349.802  5  bad
chromium@428839                   26190.6  344.454  5  bad
chromium@428840                   26250.4  393.636  5  bad
chromium@428844                   26077.2  290.556  5  bad
chromium@428860                   26263.8  356.466  5  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 661161

Test Command: .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1
Test Metric: DrawCallPerf_d3d11_null/score
Relative Change: 4.88%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1943
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8997188005526987600


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6440868926455808

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Status: WontFix (was: Untriaged)

Sign in to add a comment