Transparent Retries are too transparent in UI |
||
Issue descriptionSuppose a bot is broken, like https://chromium-swarm.appspot.com/bot?id=skia-rpi-049&sort_stats=total%3Adesc What steps will reproduce the problem? (1) Go to broken bot page. See many failed tasks and bot_died tasks at the bottom. (2) Click on a bot_died task. (3) Get confused because it links to https://chromium-swarm.appspot.com/task?id=32344a51fa476910&refresh=10, which shows success What is the expected output? Something that shows that the bot died, and that it was retried What do you see instead? The successful retry, with no indication of other failures. Please use labels and text to provide additional information.
,
Nov 1 2016
I agree the difference between tries and summary needs to be clearer for users. It's tricky to explain to users too so I'm not sure what the best route is for users. Likely something like: https://chromium-swarm.appspot.com/task?id=32344a51fa476910 replace the section Tries:2 with link to each try; [Try #1: BOT_DIED](https://chromium-swarm.appspot.com/task?id=32344a51fa476911) [Try #2: COMPLETED (SUCCESS) currently shown](https://chromium-swarm.appspot.com/task?id=32344a51fa476912) (using markdown for terseness) that may require more API calls though. :/
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/98d1837347d53ed9a540c94e3878b2625b9b2206 commit 98d1837347d53ed9a540c94e3878b2625b9b2206 Author: kjlubick <kjlubick@google.com> Date: Mon Nov 14 19:47:54 2016 Make silent task retries more obvious This adds a task-disambiguation element that shows the (silent) retries, their state and the bot. Since milo-pages are not generated for tasks not ending in 0, I added an explanation for when this happens. This also tweaks the gpu sorting order on the botlist page. I had considered making the task list on the bot-page link to the non-summary version of the task, but I decided the task-disambiguation explains more (i.e. the task was retried). BUG= 661152 Review-Url: https://codereview.chromium.org/2497663003 [modify] https://crrev.com/98d1837347d53ed9a540c94e3878b2625b9b2206/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/98d1837347d53ed9a540c94e3878b2625b9b2206/appengine/swarming/ui/res/imp/botlist/bot-list.html [modify] https://crrev.com/98d1837347d53ed9a540c94e3878b2625b9b2206/appengine/swarming/ui/res/imp/common/common-behavior.html [modify] https://crrev.com/98d1837347d53ed9a540c94e3878b2625b9b2206/appengine/swarming/ui/res/imp/common/task-behavior.html [add] https://crrev.com/98d1837347d53ed9a540c94e3878b2625b9b2206/appengine/swarming/ui/res/imp/taskpage/task-disambiguation.html [modify] https://crrev.com/98d1837347d53ed9a540c94e3878b2625b9b2206/appengine/swarming/ui/res/imp/taskpage/task-page-demo.html [modify] https://crrev.com/98d1837347d53ed9a540c94e3878b2625b9b2206/appengine/swarming/ui/res/imp/taskpage/task-page.html
,
Nov 15 2016
This is now live in chromium-swarm |
||
►
Sign in to add a comment |
||
Comment 1 by kjlubick@google.com
, Nov 1 2016