Issue metadata
Sign in to add a comment
|
Cannot access to ARC custom notifications by keyboard |
||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open the message center (2) Navigate through notifications by keyboard What is the expected output? Focus moves into ARC custom notification and a user can interact with actions in the notifications by keyboard. What do you see instead? Focus doesn't move into ARC custom notifications.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40f710956ce7f40fe60008b5da0c818cf04b49be commit 40f710956ce7f40fe60008b5da0c818cf04b49be Author: yhanada <yhanada@chromium.org> Date: Thu Jan 05 13:50:09 2017 Defer focus handling to the content if it claims to have focus. - Added |CustomNotificationView::OnContentFocused| and |CustomNotificationView::OnContentBlured| for handling a focus painter. BUG=661105 TEST=n/a; no behavior change. Review-Url: https://codereview.chromium.org/2581703003 Cr-Commit-Position: refs/heads/master@{#441645} [modify] https://crrev.com/40f710956ce7f40fe60008b5da0c818cf04b49be/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/40f710956ce7f40fe60008b5da0c818cf04b49be/ui/arc/notification/arc_custom_notification_view.h [modify] https://crrev.com/40f710956ce7f40fe60008b5da0c818cf04b49be/ui/message_center/views/custom_notification_view.cc [modify] https://crrev.com/40f710956ce7f40fe60008b5da0c818cf04b49be/ui/message_center/views/custom_notification_view.h [modify] https://crrev.com/40f710956ce7f40fe60008b5da0c818cf04b49be/ui/message_center/views/message_center_view.cc
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87b724b37d6da750c2a052e88bf828bd75ab4de0 commit 87b724b37d6da750c2a052e88bf828bd75ab4de0 Author: yhanada <yhanada@chromium.org> Date: Fri Jan 06 08:07:47 2017 Put the close button of a notification into focus chain. BUG=661105 TEST=Manual. Check that focus can move on a close button of an ARC notification by TAB. Review-Url: https://codereview.chromium.org/2610853011 Cr-Commit-Position: refs/heads/master@{#441903} [modify] https://crrev.com/87b724b37d6da750c2a052e88bf828bd75ab4de0/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/87b724b37d6da750c2a052e88bf828bd75ab4de0/ui/arc/notification/arc_custom_notification_view.h
,
Jan 20 2017
#3 introduced a crash (tracked in issue 682868). A fix is pending. But to make PFQ happy, I would revert #3 on branch 2984 and 2987 per TPM request.
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/740745497c95b7e3dbd9f1d5a0e7d0245b163bcc commit 740745497c95b7e3dbd9f1d5a0e7d0245b163bcc Author: Xiyuan Xia <xiyuan@google.com> Date: Fri Jan 20 18:43:48 2017 Revert "Put the close button of a notification into focus chain." This reverts commit 87b724b37d6da750c2a052e88bf828bd75ab4de0 on branch 2984 to make PFQ happy. BUG=682868,661105 TBR=yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2642293003 . Cr-Commit-Position: refs/branch-heads/2984@{#5} Cr-Branched-From: a2377c097a1fa051f90f9c02d96d010073fcb701-refs/heads/master@{#443964} [modify] https://crrev.com/740745497c95b7e3dbd9f1d5a0e7d0245b163bcc/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/740745497c95b7e3dbd9f1d5a0e7d0245b163bcc/ui/arc/notification/arc_custom_notification_view.h
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/921ef9abaa6c04e230104723f2d32906a8f136e1 commit 921ef9abaa6c04e230104723f2d32906a8f136e1 Author: Xiyuan Xia <xiyuan@google.com> Date: Fri Jan 20 18:46:47 2017 Revert "Put the close button of a notification into focus chain." This reverts commit 87b724b37d6da750c2a052e88bf828bd75ab4de0 on branch 2987 to make PFQ happy. BUG=682868, 661105 TBR=yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2644383002 . Cr-Commit-Position: refs/branch-heads/2987@{#4} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/921ef9abaa6c04e230104723f2d32906a8f136e1/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/921ef9abaa6c04e230104723f2d32906a8f136e1/ui/arc/notification/arc_custom_notification_view.h
,
Jan 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/190148059453a70e383e8856794ad9d43dafce3f commit 190148059453a70e383e8856794ad9d43dafce3f Author: Xiyuan Xia <xiyuan@google.com> Date: Tue Jan 24 18:10:19 2017 Revert "Revert "Put the close button of a notification into focus chain."" This reverts commit 921ef9abaa6c04e230104723f2d32906a8f136e1. Revert the temp revert to prepare for merge the fix https://codereview.chromium.org/2646143002. BUG=682868,661105 TBR=yoshiki@chromium.org Review-Url: https://codereview.chromium.org/2652043002 . Cr-Commit-Position: refs/branch-heads/2987@{#60} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/190148059453a70e383e8856794ad9d43dafce3f/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/190148059453a70e383e8856794ad9d43dafce3f/ui/arc/notification/arc_custom_notification_view.h
,
Mar 27 2017
,
Mar 28 2017
,
Apr 21 2017
,
Nov 10 2017
Issue 783092 has been merged into this issue.
,
Apr 3 2018
Issue 790946 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 7 2016