New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661096 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Nov 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Chrome crashes on clicking Manage extensions link of added extension

Project Member Reported by sc00335...@techmahindra.com, Nov 1 2016 
Version: 56.0.2906.0 Dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1) Launch chrome and go to chrome://extensions.
(2) Add the attached commands.crx extension.
(3) Click on the 'Managed Shortcuts' link once the extension gets added and observe.

Expected: KEyboard shortcuts window should get opened.
Actual: Instead chrome crashes on clicking Manage extensions link.

This is a regression issue broken in M56.

Good Build: 56.0.2902.0 
Bad Build: 56.0.2903.0
Actual_crash.ogv
1.2 MB View Download
commands.crx
1.2 KB Download

Comment 1 by sc00335...@techmahindra.com, Nov 1 2016 

Crash ids: 3db1364700000000, beffb64700000000

Comment 2 by sc00335...@techmahindra.com, Nov 1 2016

Summary: Regression: Chrome crashes on clicking Manage Shortcuts link of added extension (was: Regression: Chrome crashes on clicking Manage extensions link of added extension)

Comment 3 by brajkumar@chromium.org, Nov 1 2016

Labels: -Needs-Bisect
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Chrome crashes on clicking Manage extensions link of added extension (was: Regression: Chrome crashes on clicking Manage Shortcuts link of added extension)
Able to reproduce the issue on Ubuntu 14.04 using chrome latest Dev M56-56.0.2906.0 by following steps mentioned in the original comment. Observed browser crash while clicking on "Manage Shortcuts".

Note: Unable to reproduce this issue on Mac OS 10.12.

Stack Trace:
------------
Thread 0 CRASHED [SIGILL @ 0x00007fa2e91ec582 ] MAGIC SIGNATURE THREAD
0x00007fa2e91ec582	(chrome -./out/Release/../../chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc:161 )	(anonymous namespace)::ExtensionInstalledBubbleView::CloseBubble()
0x00007fa2e91ecaf0	(chrome -./out/Release/../../chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc:276 )	(anonymous namespace)::ExtensionInstalledBubbleView::LinkClicked(views::Link*, int)
0x00007fa2e8887e00	(chrome -./out/Release/../../ui/views/view.cc:616 )	<name omitted>
0x00007fa2e8887dff	(chrome -./out/Release/../../ui/views/view.cc:616 )	<name omitted>
0x00007fa2eabef59d	(chrome -./out/Release/../../ui/views/controls/link.cc:82 )	<name omitted>
0x00007fa2e80b3f98	(chrome -./out/Release/../../ui/events/event_dispatcher.cc:191 )	<name omitted>
0x00007fa2e80b3d4e	(chrome -./out/Release/../../ui/events/event_dispatcher.cc:86 )	<name omitted>
0x00007fa2e80b3ca8	(chrome -./out/Release/../../ui/events/event_dispatcher.cc:58 )	<name omitted>
0x00007fa2e88c18eb	(chrome -./out/Release/../../ui/views/widget/root_view.cc:447 )	<name omitted>
0x00007fa2e62187dc	(chrome -./out/Release/../../third_party/tcmalloc/chromium/src/thread_cache.h:201 )	(anonymous namespace)::do_free_with_callback(void*, void (*)(void*))
0x00007fa2e7925773	(chrome -./out/Release/../../third_party/skia/include/core/SkMatrix44.h:208 )	<name omitted>
0x00007fa2e8889bc5	(chrome -./out/Release/../../ui/views/view.cc:2053 )	<name omitted>
0x00007fa2e88c0363	(chrome -./out/Release/../../ui/views/view_targeter_delegate.cc:29 )	<name omitted>
0x00007fa2eb5a7d44	(chrome + 0x05ec1d44 )	_fini
0x00007fa2eb3a4d11	(chrome -./out/Release/../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1045 )	tc_malloc
0x00007fa2eb5a7d44	(chrome + 0x05ec1d44 )	_fini
0x00007fa2e7814fbe	(chrome -./out/Release/../../base/memory/ref_counted.h:180 )	<name omitted>
0x00007fa2e63794b7	(chrome -./out/Release/../../base/memory/weak_ptr.h:225 )	<name omitted>
0x00007fa2e7814e20	(chrome -./out/Release/../../base/memory/ref_counted.h:184 )	<name omitted>
0x00007fa2e6379466	(chrome -./out/Release/../../base/observer_list.h:205 )	base::ObserverListBase<AboutSigninInternals::Observer>::Iter<base::ObserverListBase<AboutSigninInternals::Observer> >::~Iter()
0x00007fa2e2e51d7c	(libXi.so.6.1.0 + 0x00006d7c )	
0x00007fa2e2e53400	(libXi.so.6.1.0 + 0x00008400 )	
0x00007fa2e2e54a76	(libXi.so.6.1.0 + 0x00009a76 )	
0x00007fa2e8891eb5	(chrome -./out/Release/../../ui/views/widget/widget.cc:1211 )	<name omitted>
0x00007fa2e80b3f98	(chrome -./out/Release/../../ui/events/event_dispatcher.cc:191 )	<name omitted>
0x00007fa2e80b3d4e	(chrome -./out/Release/../../ui/events/event_dispatcher.cc:86 )	<name omitted>
0x00007fa2e80b3ca8	(chrome -./out/Release/../../ui/events/event_dispatcher.cc:58 )	<name omitted>
0x00007fa2ea6b635d	(chrome -./out/Release/../../ui/events/event_processor.cc:35 )	<name omitted>
0x00007fa2ea6b65cf	(chrome -./out/Release/../../ui/events/event_source.cc:73 )	<name omitted>
0x00007fa2e88cbe6f	(chrome + 0x031e5e6f )	
0x00007fa2e88a3f35	(chrome -./out/Release/../../ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1791 )	views::DesktopWindowTreeHostX11::DispatchMouseEvent(ui::MouseEvent*)
0x00007fa2e88a3717	(chrome -./out/Release/../../ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:2138 )	views::DesktopWindowTreeHostX11::DispatchEvent(_XEvent* const&)
0x00007fa2e82e7183	(chrome -./out/Release/../../cc/tiles/tile_task_manager.cc:31 )	cc::TileTaskManagerImpl::ScheduleTasks(cc::TaskGraph*)
0x00007fa2e82e2b0c	(chrome -./out/Release/../../base/memory/ref_counted.h:194 )	<name omitted>
0x00007fa2e82eedfb	(chrome -./out/Release/../../cc/trees/layer_tree_host_impl.cc:1264 )	<name omitted>
0x00007fa2e62187dc	(chrome -./out/Release/../../third_party/tcmalloc/chromium/src/thread_cache.h:201 )	(anonymous namespace)::do_free_with_callback(void*, void (*)(void*))
0x00007fa2e62187dc	(chrome -./out/Release/../../third_party/tcmalloc/chromium/src/thread_cache.h:201 )	(anonymous namespace)::do_free_with_callback(void*, void (*)(void*))
0x00007fa2dedf692c	(libc-2.19.so -clock_gettime.c:115 )	__clock_gettime
0x00007fa2e7853d22	(chrome -./out/Release/../../base/time/time_posix.cc:107 )	<name omitted>
0x00007fa2e787afe1	(chrome -./out/Release/../../base/profiler/tracked_time.cc:51 )	<name omitted>
0x00007fa2eb44fc36	(chrome + 0x05d69c36 )	_fini
0x00007fa2eb44fcf5	(chrome + 0x05d69cf5 )	_fini
0x00007fa2e641027e	(chrome -./out/Release/../../cc/base/unique_notifier.cc:36 )	<name omitted>
0x00007fa2eb522308	(chrome + 0x05e3c308 )	_fini
0x00007fa2dedf692c	(libc-2.19.so -clock_gettime.c:115 )	__clock_gettime
0x00007fa2e7853d22	(chrome -./out/Release/../../base/time/time_posix.cc:107 )	<name omitted>
0x00007fa2e82862ff	(chrome + 0x02ba02ff )	
0x00007fa2e828636f	(chrome -./out/Release/../../base/synchronization/lock.h:27 )	<name omitted>
0x00007fa2e62187dc	(chrome -./out/Release/../../third_party/tcmalloc/chromium/src/thread_cache.h:201 )	(anonymous namespace)::do_free_with_callback(void*, void (*)(void*))
0x00007fa2e62187dc	(chrome -./out/Release/../../third_party/tcmalloc/chromium/src/thread_cache.h:201 )	(anonymous namespace)::do_free_with_callback(void*, void (*)(void*))
0x00007fa2e82e72f4	(chrome -./out/Release/../../cc/tiles/tile_task_manager.cc:37 )	cc::TileTaskManagerImpl::CheckForCompletedTasks()
0x00007fa2eb522308	(chrome + 0x05e3c308 )	_fini
0x00007fa2dedf692c	(libc-2.19.so -clock_gettime.c:115 )	__clock_gettime

Used code search for the file "extension_installed_bubble_view.cc" and suspecting the below change
Review URL: https://codereview.chromium.org/2409713002

estade@: Could you please check if this is caused with respect to your change, if not please help us in reassign the issue to the right owner. 

Thanks!

Comment 4 by woxxom@gmail.com, Nov 1 2016 

Bisect: 428033 (good) - 428037 (bad).
https://chromium.googlesource.com/chromium/src/+log/fb05b818..2b385cbf?pretty=fuller
Suspecting https://crrev.com/2409713002 as the only extension-related change.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 1 2016

Labels: FoundIn-M-56 Fracas
Users experienced this crash on the following builds:

Win Canary 56.0.2906.0 -  0.49 CPM, 2 reports, 2 clients (signature `anonymous namespace'::ExtensionInstalledBubbleView::CloseBubble)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 6 by est...@chromium.org, Nov 2 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d800ae3299fcbda1e0d9111aa83ae707c2c2fb6

commit 5d800ae3299fcbda1e0d9111aa83ae707c2c2fb6
Author: estade <estade@chromium.org>
Date: Fri Nov 04 16:37:21 2016

Don't call CloseBubble multiple times in ExtensionInstalledBubbleView

fixes crashes on clicking "manage extensions" or "sign in to chrome"

BUG= 661096 

Review-Url: https://codereview.chromium.org/2468873003
Cr-Commit-Position: refs/heads/master@{#429912}

[modify] https://crrev.com/5d800ae3299fcbda1e0d9111aa83ae707c2c2fb6/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Comment 8 by est...@chromium.org, Nov 4 2016

Labels: -M-56 M-55 Merge-Request-55
should the fix for bug 648280 be merged, this one needs merged as well
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 4 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16f346a186746f906e50a572cc93c26e42d61cf8

commit 16f346a186746f906e50a572cc93c26e42d61cf8
Author: Evan Stade <estade@chromium.org>
Date: Fri Nov 04 23:14:47 2016

Don't call CloseBubble multiple times in ExtensionInstalledBubbleView

fixes crashes on clicking "manage extensions" or "sign in to chrome"

BUG= 661096 

Review-Url: https://codereview.chromium.org/2468873003
Cr-Commit-Position: refs/heads/master@{#429912}
(cherry picked from commit 5d800ae3299fcbda1e0d9111aa83ae707c2c2fb6)

Review URL: https://codereview.chromium.org/2479743003 .

Cr-Commit-Position: refs/branch-heads/2883@{#467}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/16f346a186746f906e50a572cc93c26e42d61cf8/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Comment 10 by dimu@chromium.org, Nov 5 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)

Comment 11 by gov...@chromium.org, Nov 7 2016 

**** Bulk edit -  please ignore if not applicable ****

A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Also due to Thanksgiving holidays in US, please make sure all fixes are ready and merged to M55 latest by 5:00 PM PT Friday, 11/18/16.

Comment 12 by est...@chromium.org, Nov 7 2016

Status: Fixed (was: Started)

Comment 13 by gov...@chromium.org, Nov 7 2016

Labels: -Merge-Approved-55
Per comment #9, this is already merged to M55. So removing "Merge-Approved-55" label.

Note: Next time, please wait for approval before merging to M55.

Comment 14 by est...@chromium.org, Nov 7 2016

Labels: -Hotlist-Merge-Approved
re note: I was pinged in chat and asked to please merge this one along with the fix for bug 648280.

Comment 15 by brajkumar@chromium.org, Nov 9 2016

Labels: TE-Verified-55.0.2883.44 TE-Verified-M55
Verified this issue on Ubuntu 14.04 and Windows-10 using chrome latest Beta M55-55.0.2883.44 by following steps mentioned in the original comment. Observed no crashes by cicking on managed shortcuts button for commands.crx extension. Hence adding TE-Verified label.
Screenshot from 2016-11-09 11:30:32.png
322 KB View Download
►

Sign in to add a comment